From owner-dev-commits-src-main@freebsd.org Fri Feb 19 01:54:44 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 24985535172; Fri, 19 Feb 2021 01:54:44 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DhZQD04csz4hM2; Fri, 19 Feb 2021 01:54:44 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com [66.111.4.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bdragon/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id E3F52B8E3; Fri, 19 Feb 2021 01:54:43 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailauth.nyi.internal (Postfix) with ESMTP id 1FB9D27C0054; Thu, 18 Feb 2021 20:54:43 -0500 (EST) Received: from imap38 ([10.202.2.88]) by compute3.internal (MEProxy); Thu, 18 Feb 2021 20:54:43 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrjeehgdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecufghrlhcuvffnffculddutddmnecujfgurhepofgfgg fkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdeurhgrnhguohhnuceuvghr ghhrvghnfdcuoegsughrrghgohhnsefhrhgvvgeuufffrdhorhhgqeenucggtffrrghtth gvrhhnpeejhfeftddutdelgeekgedtgeejkeffvdejtddthefggfevuefggfefledvgefh gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegsug hrrghgohhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqddutdegvdefheek ieegqddukedutdekheduqdgsughrrghgohhnpeephfhrvggvuefuffdrohhrghesihhmrg hprdgttg X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id CCF7ACA005D; Thu, 18 Feb 2021 20:54:42 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-141-gf094924a34-fm-20210210.001-gf094924a Mime-Version: 1.0 Message-Id: In-Reply-To: <012169A0-67EC-48B7-A1CB-2A9921EF63FA@freebsd.org> References: <202102180035.11I0ZnL3070354@gitrepo.freebsd.org> <9687575c-dd7c-1496-850b-2018f4bca3da@FreeBSD.org> <3045F222-DBAC-463C-B429-075B2CFB115A@freebsd.org> <012169A0-67EC-48B7-A1CB-2A9921EF63FA@freebsd.org> Date: Thu, 18 Feb 2021 19:54:22 -0600 From: "Brandon Bergren" To: "Jessica Clarke" Cc: "Konstantin Belousov" , "John Baldwin" , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: =?UTF-8?Q?Re:_git:_24fd63e0970f_-_main_-_mips:_Don't_set_=5F=5FNO=5FTLS_?= =?UTF-8?Q?to_disable_some_uses_of_TLS.?= Content-Type: text/plain X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 01:54:44 -0000 On Thu, Feb 18, 2021, at 7:07 PM, Jessica Clarke wrote: > On 19 Feb 2021, at 00:03, Brandon Bergren wrote: > > Ok, so the mistake was not deleting it 8 years ago and instead leaving > it around to become part of the ABI. The issue you're referring to > specifically is __getCurrentRuneLocale and _ThreadRuneLocale (the > latter doesn't exist for __NO_TLS, and the former changes between > static inline and extern)? __NO_TLS should have blocked powerpc64 (and > mips) from becoming tier 2 IMO, but we're stuck with it, so yeah, it's > a major ABI break (frustratingly tiny but breaks the core system > libraries) and thus can't be MFC'ed. > > Jess Right. And I fixed it for powerpc64 for 13 finally becuase I had the excuse of "Well, we're switching to an entirely incompatible ABI due to lld not supporting ELFv1, so I might as well fix this one at the same time since we're forcing people to reinstall from scratch anyway." So yeah, in HEAD, all references to __NO_TLS can go away fully, in stable/13 the mips part probably has to stay (riscv can play the tier 3 card though), and in 12 it's baked in for life. The "(defined(__powerpc64__) && (!defined(_CALL_ELF) || _CALL_ELF == 1))" part is no longer relevant for 13 or HEAD, since the ELFv2 transition is over and done with as of the end of 2019. I probably should have taken that part out last year, since it was meant to just be a temporary compatibility shim so that people could compile both the gcc4.2 ELFv1 and llvm ELFv2 versions of 13-CURRENT out of the same tree back when we were in the middle of switching over. -- Brandon Bergren bdragon@FreeBSD.org