From owner-svn-src-head@FreeBSD.ORG  Sun Mar 13 13:15:35 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E6A62106564A;
	Sun, 13 Mar 2011 13:15:35 +0000 (UTC)
	(envelope-from alexander@leidinger.net)
Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de
	[217.11.53.44])
	by mx1.freebsd.org (Postfix) with ESMTP id 9D5318FC08;
	Sun, 13 Mar 2011 13:15:35 +0000 (UTC)
Received: from outgoing.leidinger.net (p5B1539CA.dip.t-dialin.net
	[91.21.57.202])
	by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 6589884400E;
	Sun, 13 Mar 2011 14:15:32 +0100 (CET)
Received: from unknown (IO.Leidinger.net [192.168.2.110])
	by outgoing.leidinger.net (Postfix) with ESMTP id 81D1C2AAA;
	Sun, 13 Mar 2011 14:15:29 +0100 (CET)
Date: Sun, 13 Mar 2011 14:15:28 +0100
From: Alexander Leidinger <Alexander@Leidinger.net>
To: Artem Belevich <fbsdlist@src.cx>
Message-ID: <20110313141528.000013b1@unknown>
In-Reply-To: <AANLkTimOAKLJm10dZAu2SYPeUk3agL_hsv-t7D1UHOj5@mail.gmail.com>
References: <201103120851.p2C8phoN010341@svn.freebsd.org>
	<20110312205719.00004e67@unknown>
	<AANLkTimOAKLJm10dZAu2SYPeUk3agL_hsv-t7D1UHOj5@mail.gmail.com>
X-Mailer: Claws Mail 3.7.6 (GTK+ 2.16.0; i586-pc-mingw32msvc)
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-EBL-MailScanner-Information: Please contact the ISP for more information
X-EBL-MailScanner-ID: 6589884400E.A25A9
X-EBL-MailScanner: Found to be clean
X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN,
	SpamAssassin (not cached, score=-0.923, required 6,
	autolearn=disabled, ALL_TRUSTED -1.00, TW_SV 0.08)
X-EBL-MailScanner-From: alexander@leidinger.net
X-EBL-MailScanner-Watermark: 1300626932.99198@rVUjvoaHFZTQRNB+DsHHiA
X-EBL-Spam-Status: No
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Andriy Gapon <avg@freebsd.org>
Subject: Re: svn commit: r219559 - in head/sys: amd64/linux32
 compat/freebsd32 i386/linux kern
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Mar 2011 13:15:36 -0000

On Sat, 12 Mar 2011 22:24:09 -0800 Artem Belevich <fbsdlist@src.cx>
wrote:

> >> Modified: head/sys/i386/linux/syscalls.master
> >> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 l_ha=
ndler_t handler); }
> >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 void=
 *handler); }
> >
> > What's wrong with l_handler_t?
>=20
> I don't recall the details, but I believe that the way l_handler_t is
> defined resulted in compilation errors in generated glue code. Glue
> generation code relies on '*' before the argument name in order to
> tell scalars from pointers. l_handler_t was interpreted as a scalar
> and on i386 where l_handler_t is a pointer, it produced compilation
> warning.

What about documenting it with a comment nearby?

Bye,
Alexander.