From owner-freebsd-hackers@FreeBSD.ORG  Sun Jan 26 23:35:47 2014
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx2.freebsd.org (mx2.freebsd.org [8.8.178.116])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 54D9F9F2;
 Sun, 26 Jan 2014 23:35:47 +0000 (UTC)
Received: from butcher-nb.yandex.net (hub.freebsd.org
 [IPv6:2001:1900:2254:206c::16:88])
 by mx2.freebsd.org (Postfix) with ESMTP id 1FE04228D;
 Sun, 26 Jan 2014 23:35:45 +0000 (UTC)
Message-ID: <52E59B93.90304@FreeBSD.org>
Date: Mon, 27 Jan 2014 03:34:43 +0400
From: "Andrey V. Elsukov" <ae@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: "Alexander V. Chernikov" <melifaro@yandex-team.ru>, 
 "net@freebsd.org" <net@freebsd.org>
Subject: Re: "slow path" in network code || IPv6 panic on inteface removal
References: <52E21721.5010309@yandex-team.ru>
In-Reply-To: <52E21721.5010309@yandex-team.ru>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: arch@freebsd.org, hackers@freebsd.org
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 26 Jan 2014 23:35:47 -0000

Hello, Alexander,

probably it would be better, it you split your patch into two.
The one, that implements this:

> What exactly is proposed:
> - Another one netisr queue for handling different types of packets
> - metainfo is stored in mbuf_tag attached to packet
> - ifnet departure handler taking care of packets queued from/to killed
> ifnet
> - API to register/unregister/dispath given type of traffic

And second, that shows usage example:

> #5 T2 calls nd6_ifptomac() which reads interface MAC from ifp->if_addr
> 
> #6 User inspects core generated by previous call
> 
> Using new API, we can avoid #6 by making the following code changes:
> * LLE timer does not drop/reacquire LLE lock
> * we require nd6_ns_output callers to lock LLE if it is provided
> * nd6_ns_output() uses "slow" path instead of sending mbuf to
> ip6_output() immediately if LLE is not NULL.

-- 
WBR, Andrey V. Elsukov