From owner-freebsd-standards@FreeBSD.ORG  Wed Jun  8 10:31:00 2005
Return-Path: <owner-freebsd-standards@FreeBSD.ORG>
X-Original-To: standards@freebsd.org
Delivered-To: freebsd-standards@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6499216A426
	for <standards@freebsd.org>; Wed,  8 Jun 2005 10:31:00 +0000 (GMT)
	(envelope-from stefan@fafoe.narf.at)
Received: from fafoe.narf.at (chello213047085026.6.14.vie.surfer.at
	[213.47.85.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0F30743D4C
	for <standards@freebsd.org>; Wed,  8 Jun 2005 10:30:59 +0000 (GMT)
	(envelope-from stefan@fafoe.narf.at)
Received: from wombat.fafoe.narf.at (wombat.fafoe.narf.at [192.168.1.42])
	by fafoe.narf.at (Postfix) with ESMTP id F1FC13FA7;
	Wed,  8 Jun 2005 12:30:51 +0200 (CEST)
Received: by wombat.fafoe.narf.at (Postfix, from userid 1001)
	id 6C05A2DD; Wed,  8 Jun 2005 12:30:47 +0200 (CEST)
Date: Wed, 8 Jun 2005 12:30:47 +0200
From: Stefan Farfeleder <stefan@fafoe.narf.at>
To: Michael Reifenberger <mike@Reifenberger.com>
Message-ID: <20050608103045.GC16848@wombat.fafoe.narf.at>
Mail-Followup-To: Michael Reifenberger <mike@Reifenberger.com>,
	standards@freebsd.org
References: <20050608094851.D29843@fw.reifenberger.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050608094851.D29843@fw.reifenberger.com>
User-Agent: Mutt/1.5.9i
Cc: standards@freebsd.org
Subject: Re: libstand functions not ansi-c compiliant
X-BeenThere: freebsd-standards@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Standards compliance <freebsd-standards.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-standards>, 
	<mailto:freebsd-standards-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-standards>
List-Post: <mailto:freebsd-standards@freebsd.org>
List-Help: <mailto:freebsd-standards-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-standards>, 
	<mailto:freebsd-standards-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jun 2005 10:31:00 -0000

On Wed, Jun 08, 2005 at 09:53:15AM +0200, Michael Reifenberger wrote:
> Hi,
> as it seems are a few functions as defined/implemented in libstand
> not ansi-c compiant: putchar, vprintf, vsprintf.
> They are defined to return void instead of int.

libstand isn't intended to be a standards-compliant C library.  I'm
afraid I don't see the advantages of your proposed changes.

> -void
> +int
>  vprintf(const char *fmt, va_list ap)
>  {
> +	int retval;
> 
>  	kvprintf(fmt, putchar, NULL, 10, ap);

retval = kvprintf(fmt, putchar, NULL, 10, ap);

> +	return(retval);
>  }

> @@ -369,7 +369,7 @@
>   */
>  extern int		getchar(void);
>  extern int		ischar(void);
> -extern void		putchar(int);
> +extern int		putchar(int);

You can't just change the return type in the header without changing all
definitions of putchar().

Stefan