From owner-p4-projects@FreeBSD.ORG Fri Apr 14 05:43:43 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 9D43616A405; Fri, 14 Apr 2006 05:43:43 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5E6FB16A401; Fri, 14 Apr 2006 05:43:43 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id F21EA43D45; Fri, 14 Apr 2006 05:43:42 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k3E5haW0005332; Thu, 13 Apr 2006 23:43:36 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Thu, 13 Apr 2006 23:43:49 -0600 (MDT) Message-Id: <20060413.234349.66709460.imp@bsdimp.com> To: marcel@xcllnt.net From: "M. Warner Losh" In-Reply-To: <014B1689-1A9A-4AC3-BE76-AF8E35FF0A9C@xcllnt.net> References: <200604121450.k3CEoUJh071640@repoman.freebsd.org> <200604121202.29736.jhb@freebsd.org> <014B1689-1A9A-4AC3-BE76-AF8E35FF0A9C@xcllnt.net> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: perforce@freebsd.org, jhb@freebsd.org Subject: Re: PERFORCE change 95068 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2006 05:43:43 -0000 In message: <014B1689-1A9A-4AC3-BE76-AF8E35FF0A9C@xcllnt.net> Marcel Moolenaar writes: : : On Apr 12, 2006, at 9:02 AM, John Baldwin wrote: : : > On Wednesday 12 April 2006 10:50, Marcel Moolenaar wrote: : >> http://perforce.freebsd.org/chv.cgi?CH=95068 : >> : >> Change 95068 by marcel@marcel_nfs on 2006/04/12 14:49:30 : >> : >> Replace the rmask and rval arrays with vendor, device, subvendor : >> and subdevice variables. When subvendor is 0xffff, don't test the : >> subvendor and subdevice values. This strips 24 bytes from the : >> description. : >> While here, sort the list on vendor, device, subvendor and : >> subdevice. : > : > I guess you expanded any entries that were using masks other than : > 0xffff? (I think there were only a handful if any). : : Not yet. I looked at the latest pucdata.c in NetBSD and more entries : with masks other than 0xffff have been added. While the handful we : had looked like mistakes (was 0xfffc, should probably be 0xfffe), the : new ones don't. I need to investigate, because if the mask is used : as a quick and dirty way to add multiple boards with a single entry : then I'm not sure it's a good thing. For different boards, different : descriptions are better. In that case I will expand. Otherwise I may : end up bringing back the mask. : : The entries in question have a /* MASK */ comment as a reminder. You might want to take a look at some of what I did in my newcard tree, since I reduce the data quite a bit. I think I may have committed it to head, but I might have forgotten. The mask was indeed for multiple boards to make the table smaller, but it really made it larger. Warner