From owner-svn-src-all@FreeBSD.ORG Sat Dec 15 13:29:12 2012 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2520E58E; Sat, 15 Dec 2012 13:29:12 +0000 (UTC) (envelope-from bright@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id F0ED08FC12; Sat, 15 Dec 2012 13:29:11 +0000 (UTC) Received: from Alfreds-MacBook-Pro-6.local (c-67-180-208-218.hsd1.ca.comcast.net [67.180.208.218]) by elvis.mu.org (Postfix) with ESMTPSA id 1DBF41A3C1B; Sat, 15 Dec 2012 05:29:11 -0800 (PST) Message-ID: <50CC7B26.5000708@mu.org> Date: Sat, 15 Dec 2012 05:29:10 -0800 From: Alfred Perlstein User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Gleb Smirnoff Subject: Re: svn commit: r244112 - head/sys/kern References: <201212110708.qBB78EWx025288@svn.freebsd.org> <50C9271C.70803@mu.org> <20121213090215.GP97487@FreeBSD.org> <201212141149.07671.jhb@freebsd.org> <50CBC285.7060307@mu.org> <20121215161414.V1029@besplex.bde.org> <50CC6E8D.6040707@mu.org> <20121215130149.GB94420@FreeBSD.org> In-Reply-To: <20121215130149.GB94420@FreeBSD.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Cc: Adrian Chadd , src-committers@FreeBSD.org, John Baldwin , svn-src-all@FreeBSD.org, Andriy Gapon , Navdeep Parhar , svn-src-head@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Dec 2012 13:29:12 -0000 On 12/15/12 5:01 AM, Gleb Smirnoff wrote: > On Sat, Dec 15, 2012 at 04:35:25AM -0800, Alfred Perlstein wrote: > A> People keep beating this drum "all invariants/panics are there for a > A> reason", no, some happen to be bugs, and when I'm shipping code to a > A> customer, I may need to skip one of these buggy assertions. > > Yes, if you know any buggy assertions, please remove them from FreeBSD tree. > > A> Some people have responded to this by saying "alfred show me the buggy > A> assertions" to which my response is two fold "firstly, you're calling me > A> a liar which I do not appreciate, second prove to me that all the 1000s > A> of asserts have zero bugs and are not overly zealous about calling panic." > > We are not going to prove that. If you claim that some assertion is buggy, > you prove that it is buggy and happily remove it from source tree. Noone > is going to spend time proving you that 1000s of assertions are not buggy. > > Home reading for you: > > http://en.wikipedia.org/wiki/Russell%27s_teapot > Here is some reading for you: ------------------------------------------------------------------------ r244044 | adrian | 2012-12-08 17:08:44 -0800 (Sat, 08 Dec 2012) | 10 lines Don't panic if the stageq here is empty; just fall through with NULL pointers and leave the stage queue flush routine to just do nothing (since both head and tail here will be NULL.) This should quieten the "stageq empty" panic where the stageq itself is empty, but it won't fix the second KASSERT() here "staging queue empty" as that's likely a different underlying problem. PR: kern/174283 ------------------------------------------------------------------------ svn diff -r244043:244044 This kassert bug has existed since rev 190579: r190579 | sam | 2009-03-30 14:53:27 -0700 (Mon, 30 Mar 2009) | 25 lines thanks, -Alfred