From owner-svn-src-head@FreeBSD.ORG Sat Aug 10 19:35:12 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id CAFE129D; Sat, 10 Aug 2013 19:35:12 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6649E2CBE; Sat, 10 Aug 2013 19:35:12 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id r7AJZ6N6092923; Sat, 10 Aug 2013 22:35:06 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua r7AJZ6N6092923 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id r7AJZ6lY092921; Sat, 10 Aug 2013 22:35:06 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 10 Aug 2013 22:35:06 +0300 From: Konstantin Belousov To: Peter Wemm Subject: Re: svn commit: r254185 - head/sys/modules/random Message-ID: <20130810193506.GH4972@kib.kiev.ua> References: <201308101823.r7AINS22019611@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6mSV51rYMGA4/B6J" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Aug 2013 19:35:13 -0000 --6mSV51rYMGA4/B6J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 10, 2013 at 12:27:54PM -0700, Peter Wemm wrote: > On Sat, Aug 10, 2013 at 11:23 AM, Konstantin Belousov w= rote: > > Author: kib > > Date: Sat Aug 10 18:23:28 2013 > > New Revision: 254185 > > URL: http://svnweb.freebsd.org/changeset/base/254185 > > > > Log: > > Restore the ability to kldload random.ko, by linking in the newly > > added random_adaptors.c. > > > > Modified: > > head/sys/modules/random/Makefile > > > > Modified: head/sys/modules/random/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/modules/random/Makefile Sat Aug 10 18:23:18 2013 = (r254184) > > +++ head/sys/modules/random/Makefile Sat Aug 10 18:23:28 2013 = (r254185) > > @@ -5,7 +5,7 @@ > > .PATH: ${.CURDIR}/../../crypto/sha2 > > > > KMOD=3D random > > -SRCS=3D randomdev.c probe.c > > +SRCS=3D randomdev.c random_adaptors.c probe.c > > .if ${MACHINE} =3D=3D "amd64" || ${MACHINE} =3D=3D "i386" > > SRCS+=3D nehemiah.c > > SRCS+=3D ivy.c >=20 > However, random_adapters.c is "standard": > # grep random files > dev/random/harvest.c standard > dev/random/hash.c optional random > dev/random/probe.c optional random > dev/random/random_adaptors.c standard > dev/random/randomdev.c optional random > dev/random/randomdev_soft.c optional random > dev/random/yarrow.c optional random >=20 > I understand why harvest.c is standard - it's called by drivers. But > wouldn't your change to the module above duplicate the module list > into two separate namespaces? Oops, my change is wrong. Apparently, I did not re-configured my kernel where the random.ko module failed the load. Reverting now, thank you for noticing. --6mSV51rYMGA4/B6J Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQIcBAEBAgAGBQJSBpXpAAoJEJDCuSvBvK1BU4AQAI2x97FytthZOBEIDqq9qaih lvTD0hvL2+r7nLV3ut/4wMU/0ts3WW+MKaT+8br69NKvvNy1UhoKPpx+ar7hFPw2 QN54pGon3QLlC9GKaJwlJBFqqZaBQSDafC0IsK1UReBC6D2sgAfRgNu2Spxn+9J4 fIr6p8Y9lPvEtJyN2D9vkQx4W1WBY9s0a04urldbxNOSI9CaKOiLRorhLBcK5TYZ fQK+1sXiJh2V8kllU90PJsVDc9+LL1F9OWgWM20DgyniYAC1BYI7J45oVYpOKq+b 7rwkUbhn8IT2dB48dYz/7E4eAOwNgCxvQZZsnhSrtL6m831DatbMkDyfQoJucxU+ QYlpqdM0S0agEGz3hck2g9aYXm0bUVgqKVqoD2bhhNJDvXh8XzNZBG3liIGkB5Or DiqD/BOTNhgAnA9jPoQZJvC7uUtvowhS+1x11toT2/Pw4c6k6nOE3HTR86cO1lNm 37M3aasja/ypurlWSpZ70onfYrJP/oE4z4VAYWsiVLNqFoipmjH/arFxfFV/uO32 yLawwD0tIsvhCrsI3v7fE22bPosjkyRxlcEzffz9lHNk0jAIV9Mv9qxwU7XfeJ69 8Mghc2sm8WDJstFGaojLUQTQaa2a5t7D47cZ/uWcjRj4a/BPbakDuL4r9DKC2j4R A8b9li6ffcnz4LH/R6ng =Pwni -----END PGP SIGNATURE----- --6mSV51rYMGA4/B6J--