Date: Sat, 14 Apr 2007 22:12:22 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Stanislav Sedov <stas@FreeBSD.org> Cc: cvs-ports@freebsd.org, Andrew Pantyukhin <infofarmer@FreeBSD.org>, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/www Makefile ports/www/xpi-vimperator Makefile distinfo pkg-descr Message-ID: <20070414221222.GA83055@FreeBSD.org> In-Reply-To: <20070415020616.df924d69.stas@FreeBSD.org> References: <200704142021.l3EKLwT6071007@repoman.freebsd.org> <cb5206420704141359g3f7f44f2m4cfb54010369ec34@mail.gmail.com> <20070415011545.d25b8107.stas@FreeBSD.org> <cb5206420704141428n551a5228i186c931714c9ba@mail.gmail.com> <20070415020616.df924d69.stas@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Apr 15, 2007 at 02:06:16AM +0400, Stanislav Sedov wrote:
> On Sun, 15 Apr 2007 01:28:36 +0400
> "Andrew Pantyukhin" <infofarmer@FreeBSD.org> mentioned:
> > >
> > > Yeah, i was amazingly glad to discover it:-)
> > >
> > > > -MASTER_SITES= ${MASTER_SITE_MOZDEV}
> > > > -MASTER_SITE_SUBDIR= ${PORTNAME}
> > > > -DISTNAME= ${PORTNAME}_${PORTVERSION}
> > > > +MASTER_SITES= MOZDEV
> > > > +DISTNAME= ${PORTNAME}_${DISTVERSION}
> > >
> > > Hmm. Why use ${DISTVERSION} instead of PORTVERSION?
> >
> > grep '^DISTNAME' /usr/ports/Mk/bsd.port.mk
> >
>
> Thanks for explanation, I obviously was not informed about this file;-)
> Seriously, I see no reason to use ${DISTVERSION} instead of
> PORTVERSION, and you didn't give one.
In most cases, it's a noop. However, DISTVERSION is more generic, since
it takes care of beta/rc/pre affixes for you (i.e. yields correct
PORTVERSION which should pass pkg_version -t test when updating to final
release).
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070414221222.GA83055>