Date: Thu, 22 Aug 2002 18:51:44 -0400 From: Mike Barcroft <mike@FreeBSD.org> To: David O'Brien <obrien@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include ctype.h err.h grp.h inttypes.h monetary.h netdb.h pwd.h runetype.h search.h signal.h stddef.h stdio.h stdlib.h string.h strings.h time.h timeconv.h unistd.h vis.h wchar.h wctype.h src/include/arpa inet.h src/lib/libc/locale ... Message-ID: <20020822185144.F62302@espresso.q9media.com> In-Reply-To: <20020822120831.A91742@hub.freebsd.org>; from obrien@FreeBSD.ORG on Thu, Aug 22, 2002 at 12:08:31PM -0700 References: <200208211620.g7LGK2SZ078421@freefall.freebsd.org> <20020822120831.A91742@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
David O'Brien <obrien@FreeBSD.ORG> writes: > On Wed, Aug 21, 2002 at 09:20:02AM -0700, Mike Barcroft wrote: > > Added files: > > sys/alpha/include _types.h > > sys/arm/include _types.h > > sys/i386/include _types.h > > sys/ia64/include _types.h > > sys/powerpc/include _types.h > > sys/sparc64/include _types.h > > sys/x86_64/include _types.h > > Eeek! Talk about something that should have been a repo copy -- we just > made it harder to track history. For some reason I thought you were > going to have ansi.h repo copied to _types.h before the commit. I'm not at all sure whether a repo copy is appropriate. Since the history would just be ansi.h, followed by the next revision where every line is deleted and added differently. Revision history is only useful IMO when you can get meaningful diffs between revs. Also, we would lose types.h's history if we did that. I wanted the history to be clear that this is derived from two files, but is really a new file with a new way of doing things. > > Reviewed by: jake, obrien > > Probably should have been "Parts not liked by: obrien". I still think we > had too many gratitious changes. Not the lest of which is renaming the > file which makes history and MFC's harder. Most of the header changes related to standards aren't being MFC'd, usually because they fix namespace issues and have the potential to break buggy applications. I'm not aware of many other header changes. I needed to touch most of the headers to get them to retrieve types from a MI location, so I decided to fix some of the other issues that Bruce had brought up. I detailed these in response to some of your objections when you were reviewing the patch and thought you were satisfied with them. I won't bother going over them again, unless someone would like me to. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020822185144.F62302>