Date: Fri, 27 Jul 2012 18:04:52 +0200 From: Guido Falsi <madpilot@FreeBSD.org> To: Jeremy Messenger <mezz.freebsd@gmail.com> Cc: gnome@freebsd.org, Chris Rees <crees@freebsd.org>, Thomas Abthorpe <tabthorpe@freebsd.org> Subject: Re: [PATCH] Gnucash port update and fix for pkgconf Message-ID: <20120727160452.GF22954@megatron.madpilot.net> In-Reply-To: <CADLFttda7EPPYS73iQSWxcj8g78G3O7=y0T4uMBdwrjBGQ0d_Q@mail.gmail.com> References: <20120727153119.GE22954@megatron.madpilot.net> <CADLFttda7EPPYS73iQSWxcj8g78G3O7=y0T4uMBdwrjBGQ0d_Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jul 27, 2012 at 10:50:40AM -0500, Jeremy Messenger wrote: > On Fri, Jul 27, 2012 at 10:31 AM, Guido Falsi <madpilot@freebsd.org> wrote: > > Hi! > > > > The finance/gnucash port is broken right now. > > > > It contains an improper use of pkg-config which was innocuous, but is > > fatal with pkgconf. It causes an invalid Makefile to be generated by > > configure. > > > > Since a new version is also out I made a patch with a quick and dirty > > fix for the brokenness. > > > > The fix just forces a bogus value in the configure script in place of a > > backtick comamnd. That variable really looks unused anyway by the build > > system. GnuCash builds fine in tinderbox and wiorks correctly on a real > > system with real data. > > > > I'm attaching it requesting approval to commit it. > > > > I also wrote a bug report for this on the gnome bugzilla, waiting > > feedback. ( https://bugzilla.gnome.org/show_bug.cgi?id=680708 ) > > You have my approval. Yes, it does look like it's just some leftover > and need to be removed. Just let you know about --version can be > changed to --modversion if you find other ports that have like this. > Thanks! > > $PKG_CONFIG --version xml > > To: > > $PKG_CONFIG --modversion libxml-2.0 This is good to know! Thanks! Also the bug I filed had a very fast turnover and the removal of that variable has already been committed to their tree. So this will be a temporary fix till the next update, I hope. -- Guido Falsi <madpilot@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120727160452.GF22954>