Date: Fri, 29 Mar 2019 14:35:50 +0000 From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 230619] pf: tables use non SMP-friendly counters Message-ID: <bug-230619-16861-AwhGnQatjc@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-230619-16861@https.bugs.freebsd.org/bugzilla/> References: <bug-230619-16861@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230619 --- Comment #10 from commit-hook@freebsd.org --- A commit references this bug: Author: kp Date: Fri Mar 29 14:34:52 UTC 2019 New revision: 345692 URL: https://svnweb.freebsd.org/changeset/base/345692 Log: MFC r345177: pf :Use counter(9) in pf tables. The counters of pf tables are updated outside the rule lock. That means s= tate updates might overwrite each other. Furthermore allocation and freeing of counters happens outside the lock as well. Use counter(9) for the counters, and always allocate the counter table element, so that the race condition cannot happen any more. PR: 230619 Submitted by: Kajetan Staszkiewicz <vegeta@tuxpowered.net> Changes: _U stable/12/ stable/12/sys/net/pfvar.h stable/12/sys/netpfil/pf/pf_table.c --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-230619-16861-AwhGnQatjc>