From owner-cvs-src@FreeBSD.ORG Tue Feb 3 08:13:57 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C0E8816A4CE for ; Tue, 3 Feb 2004 08:13:57 -0800 (PST) Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9A7CB43D45 for ; Tue, 3 Feb 2004 08:13:52 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 14994 invoked from network); 3 Feb 2004 16:13:52 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 3 Feb 2004 16:13:52 -0000 Received: from 10.50.40.205 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.10/8.12.10) with ESMTP id i13GDlM0000719; Tue, 3 Feb 2004 11:13:47 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: "Bjoern A. Zeeb" Date: Tue, 3 Feb 2004 11:14:25 -0500 User-Agent: KMail/1.5.4 References: <200402022322.i12NMOVR098769@repoman.freebsd.org> <200402031013.22310.jhb@FreeBSD.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200402031114.25978.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2004 16:13:58 -0000 On Tuesday 03 February 2004 10:50 am, Bjoern A. Zeeb wrote: > On Tue, 3 Feb 2004, John Baldwin wrote: > > On Tuesday 03 February 2004 01:18 am, Bjoern A. Zeeb wrote: > > > On Mon, 2 Feb 2004, John Baldwin wrote: > > > > > > Hi, > > > > > > > jhb 2004/02/02 15:22:24 PST > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > sys/i386/i386 machdep.c > > > > Log: > > > > Set PCPU_GET(curpcb) for the BSP to thread0's pcb. Otherwise, the > > > > boot CPU doesn't have a pcb until after it's first context switch. > > > > This can cause secondary panics if a page fault happens during > > > > bootup. > > > > > > > > Revision Changes Path > > > > 1.586 +1 -0 src/sys/i386/i386/machdep.c > > > > > > this gave me a fatal trap 9 gen. protection fault while in km > > > last time I tried with your patch. > > > > You have a double panic and this fixed the first panic. You are still > > getting another panic that I'm not sure how to fix. > > *hmm* > > while this is true w/o ACPI enabled with ACPI enabled I do not get > a panic while booting a kernel prior to this commit (which is > equal to the patch you had sent me). > > With your patch (thus also with this commit I guess) I do get the > panic with and without ACPI. > > Conclusion: with this patch/commit I will no longer be able to boot > this problematic machine here. This patch cannot possibly cause a panic. It now takes a variable that was set to NULL, and gives it an initial value. Before this change, places would panic with a page fault when they tried to access this variable before it was initialized. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org