Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 16 Oct 2015 07:57:17 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 203360] graphics/xfractint: unbreak by updating to 20.04p14
Message-ID:  <bug-203360-13-F4DRcWzmEI@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-203360-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-203360-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203360

Alexey Dokuchaev <danfe@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danfe@FreeBSD.org
         Resolution|---                         |FIXED
             Status|New                         |Closed

--- Comment #2 from Alexey Dokuchaev <danfe@FreeBSD.org> ---
Thanks for the patch, quite good overall.  I've thrown in some extra
improvements and style fixes, most notably:

- portlint(1) suggesting to use ${FALSE} instead of "false" in DESKTOP_ENTRIES
is bogus: fd.org spec requires this field to be literal "true" or "false" --
it's a property, not a command, while our ${FALSE} is really false(1).  This is
a long-standing bug (false positive) of portlint(1);

- Dropping workarounds for older math functions has to be conditional because
new functions were not merged to stable/9;

- I've decided to leave existing patches untouched, because commit diff already
contained enough changes, and I did not want to add more non-functional noise
to it.

Hope you don't mind!

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-203360-13-F4DRcWzmEI>