From owner-p4-projects@FreeBSD.ORG Sun Mar 9 19:56:44 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 212F61065673; Sun, 9 Mar 2008 19:56:44 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D4E391065670 for ; Sun, 9 Mar 2008 19:56:43 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B86578FC14 for ; Sun, 9 Mar 2008 19:56:43 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m29JuhMs063397 for ; Sun, 9 Mar 2008 19:56:43 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m29JuhlM063392 for perforce@freebsd.org; Sun, 9 Mar 2008 19:56:43 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Date: Sun, 9 Mar 2008 19:56:43 GMT Message-Id: <200803091956.m29JuhlM063392@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson To: Perforce Change Reviews Cc: Subject: PERFORCE change 137250 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Mar 2008 19:56:44 -0000 http://perforce.freebsd.org/chv.cgi?CH=137250 Change 137250 by rwatson@rwatson_cinnamon on 2008/03/09 19:55:49 Don't expose selection of a "default" via bpf.h where userspace or other parts might find it -- selection of a default for new BPF devices is in the kernel BPF implementation when the new device is created. Affected files ... .. //depot/projects/zcopybpf/src/sys/net/bpf.c#45 edit .. //depot/projects/zcopybpf/src/sys/net/bpf.h#23 edit Differences ... ==== //depot/projects/zcopybpf/src/sys/net/bpf.c#45 (text+ko) ==== @@ -562,7 +562,7 @@ * particular buffer method. */ bpf_buffer_init(d); - d->bd_bufmode = BPF_BUFMODE_DEFAULT; + d->bd_bufmode = BPF_BUFMODE_BUFFER; d->bd_sig = SIGIO; d->bd_direction = BPF_D_INOUT; d->bd_pid = td->td_proc->p_pid; ==== //depot/projects/zcopybpf/src/sys/net/bpf.h#23 (text+ko) ==== @@ -103,8 +103,6 @@ #define BPF_BUFMODE_BUFFER 1 /* Kernel buffers with read(). */ #define BPF_BUFMODE_ZBUF 2 /* Zero-copy buffers. */ -#define BPF_BUFMODE_DEFAULT BPF_BUFMODE_BUFFER /* Default. */ - /*- * Struct used by BIOCSETZBUF, BIOCROTZBUF: describes up to two zero-copy * buffer as used by BPF.