Date: Thu, 24 May 2007 12:16:33 -0400 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Stephen Montgomery-Smith <stephen@math.missouri.edu> Cc: gnome@freebsd.org, pav@freebsd.org, freebsd-ports@freebsd.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: More speed increases for make-ing ports Message-ID: <1180023393.10757.29.camel@shumai.marcuscom.com> In-Reply-To: <46558678.3020704@math.missouri.edu> References: <465291FB.4010901@math.missouri.edu> <20070522071941.GB59910@xor.obsecurity.org> <4652FFB4.8060107@math.missouri.edu> <1179846295.52353.27.camel@pav.hide.vol.cz> <4653349D.7080608@math.missouri.edu> <46533D66.1070305@math.missouri.edu> <1179868612.83498.6.camel@ikaros.oook.cz> <1179869940.83498.9.camel@ikaros.oook.cz> <20070522165525.S52261@math.missouri.edu> <1179871899.83498.10.camel@ikaros.oook.cz> <20070522172627.A52261@math.missouri.edu> <465398E0.40404@math.missouri.edu> <1179907804.60308.1.camel@pav.hide.vol.cz> <4654E491.5000700@math.missouri.edu> <1179995317.66903.17.camel@pav.hide.vol.cz> <46558678.3020704@math.missouri.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-RPkmbzdP9Xypc9VeDS8o Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 2007-05-24 at 07:35 -0500, Stephen Montgomery-Smith wrote: > Pav Lucistnik wrote: > > Stephen Montgomery-Smith p=C3=AD=C5=A1e v st 23. 05. 2007 v 20:04 -0500= : > >=20 > >> I'm getting kind of uncomfortable with the patch. I looked some more > >> in=20 > >> bsd.gnome.mk and it seems to me that the suggested patch is really=20 > >> equivalent to the patch enclosed here. > >> > >> Why did the writer of bsd.gnome.mk have the rather complicated=20 > >> construction which I am proposing to replace? > >=20 > > I don't know, we'd have to ask Joe Marcus. Here is the revision in > > question: > >=20 > > http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.gnome.mk.diff?r1=3D1= .22;r2=3D1.23 > >=20 > > You're basically reverting that revision. Perhaps our make(1) wasn't > > smart enough those four years ago, I don't know. >=20 > I'm not really reverting that revision. As it was prior to that=20 > revision, I can see it not working under many circumstances. Namely, if=20 > ${component} appears more than once in ${_USE_GNOME} - something that=20 > will happen frequently - the test will not work. >=20 > My revision seems the obvious way to do it to me, but I can see that if=20 > someone was working with what Joe was working with, that one could be=20 > lead to think up his revision. I know that I myself have missed the=20 > obvious in many circumstance. I believe this will work, but it's been so long since I did this work. I think the problem was that :M used to match "eel" when USE_GNOME contained "eel2". But that doesn't appear to be the case anymore. Joe --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-RPkmbzdP9Xypc9VeDS8o Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQBGVbpfb2iPiv4Uz4cRAv2FAKCeRmWalB9yNhTjNmL34jGXoWc+agCgmm8G 60gzjpmAYAhQPfegFMlMH6E= =yiZ1 -----END PGP SIGNATURE----- --=-RPkmbzdP9Xypc9VeDS8o--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1180023393.10757.29.camel>