From owner-freebsd-net@FreeBSD.ORG  Wed Nov 23 15:07:34 2011
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 60DEE1065673
	for <freebsd-net@freebsd.org>; Wed, 23 Nov 2011 15:07:34 +0000 (UTC)
	(envelope-from nvass@gmx.com)
Received: from mailout-eu.gmx.com (mailout-eu.gmx.com [213.165.64.43])
	by mx1.freebsd.org (Postfix) with SMTP id AF0D88FC0C
	for <freebsd-net@freebsd.org>; Wed, 23 Nov 2011 15:07:33 +0000 (UTC)
Received: (qmail invoked by alias); 23 Nov 2011 15:07:32 -0000
Received: from adsl-9.109.242.133.tellas.gr (EHLO [192.168.73.193])
	[109.242.133.9]
	by mail.gmx.com (mp-eu001) with SMTP; 23 Nov 2011 16:07:32 +0100
X-Authenticated: #46156728
X-Provags-ID: V01U2FsdGVkX19X1OAzo/hX6FSd7uIZPCEBhNETSDqmZ42J9Bo1l/
	eYoQPYwskqHno9
Message-ID: <4ECD0C28.4060606@gmx.com>
Date: Wed, 23 Nov 2011 17:07:20 +0200
From: Nikos Vassiliadis <nvass@gmx.com>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US;
	rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10
MIME-Version: 1.0
To: Marko Zec <zec@fer.hr>
References: <4EC63D37.4050105@gmx.com> <20111123112204.GY96616@glebius.int.ru>
	<4ECCF257.9090801@gmx.com> <201111231453.37900.zec@fer.hr>
In-Reply-To: <201111231453.37900.zec@fer.hr>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
X-Y-GMX-Trusted: 0
Cc: freebsd-net@freebsd.org
Subject: Re: arprequest triggered panic
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Nov 2011 15:07:34 -0000

On 11/23/2011 3:53 PM, Marko Zec wrote:
> On Wednesday 23 November 2011 14:17:11 Nikos Vassiliadis wrote:
>> On 11/23/2011 1:22 PM, Gleb Smirnoff wrote:
>>> I'd suspect VIMAGE. Can you please try w/o it and if it appears to be
>>> VIMAGE-related, then please file a PR.
>>
>> It seems VIMAGE related. I'll ask at virtualization@.
>
>  From the backtrace it looks like the curvnet context is not properly set in a
> timer-driven call graph originating at lagg_port_setlladdr().
>
> Perhaps this (untested) patch could help:
>
> --- //depot/user/zec/vimage_8/src/sys/net/if_lagg.c     2011-09-06
> 05:45:07.000000000 0000
> +++ /u/marko/p4/zec/vimage_8/src/sys/net/if_lagg.c      2011-09-06
> 05:45:07.000000000 0000
> @@ -468,7 +468,9 @@
>                  ifp = llq->llq_ifp;
>
>                  /* Set the link layer address */
> +               CURVNET_SET(ifp->if_vnet);
>                  error = if_setlladdr(ifp, llq->llq_lladdr, ETHER_ADDR_LEN);
> +               CURVNET_RESTORE();
>                  if (error)
>                          printf("%s: setlladdr failed on %s\n", __func__,
>                              ifp->if_xname);

Yes, that fixes the panic.

Thanks Marko, Nikos