From owner-freebsd-hackers@FreeBSD.ORG Fri Nov 11 01:21:00 2005 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4EF1A16A41F; Fri, 11 Nov 2005 01:21:00 +0000 (GMT) (envelope-from craig@tobuj.gank.org) Received: from ion.gank.org (ion.gank.org [69.55.238.164]) by mx1.FreeBSD.org (Postfix) with ESMTP id 192F843D45; Fri, 11 Nov 2005 01:21:00 +0000 (GMT) (envelope-from craig@tobuj.gank.org) Received: by ion.gank.org (mail, from userid 1001) id E3BE52D2D3; Thu, 10 Nov 2005 19:20:59 -0600 (CST) Date: Thu, 10 Nov 2005 19:20:57 -0600 From: Craig Boston To: Pawel Jakub Dawidek Message-ID: <20051111012057.GA16592@nowhere> Mail-Followup-To: Craig Boston , Pawel Jakub Dawidek , freebsd-hackers@freebsd.org References: <20051028040450.GB50419@nowhere> <20051101104136.GA2116@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051101104136.GA2116@garage.freebsd.pl> User-Agent: Mutt/1.4.2.1i Cc: freebsd-hackers@freebsd.org Subject: Re: [PATCH] IPv6 support for ggate X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2005 01:21:00 -0000 On Tue, Nov 01, 2005 at 11:41:36AM +0100, Pawel Jakub Dawidek wrote: > I'll be grateful if you could file PR and send me its number. Thanks! I just submitted version 2 of the patch as bin/88821. > Thanks a lot! Unfortunately I don't have time to setup test environment > (I don't use ipv6 at all) and it can take a while before I'll be ready > for committing this (if noone else beat me on this). No problem, I can very much identify with not having enough time. I'm no stranger to maintaining local patches, so no hurry. For anyone following along who wants to try this out, grab the patch from the PR rather than the one I posted earlier. Please test even if you don't use IPv6 to make sure everything still works. The new patch has several improvements over the first one: * Much cleaner in a few places (notably mask handling & address binding) * ggated now allows binding to an arbitrary number of local addresses, just specify -a for each one you want to use * Eliminates most cases of conditional code on AF_*. The only ones left deal with network masks for access control that can't really be generalized Craig