From owner-cvs-all@FreeBSD.ORG  Wed Oct 26 19:57:05 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id F161E16A41F;
	Wed, 26 Oct 2005 19:57:04 +0000 (GMT) (envelope-from pjd@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9A08243D49;
	Wed, 26 Oct 2005 19:57:04 +0000 (GMT) (envelope-from pjd@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j9QJv4RO091619;
	Wed, 26 Oct 2005 19:57:04 GMT (envelope-from pjd@repoman.freebsd.org)
Received: (from pjd@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j9QJv438091618;
	Wed, 26 Oct 2005 19:57:04 GMT (envelope-from pjd)
Message-Id: <200510261957.j9QJv438091618@repoman.freebsd.org>
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Date: Wed, 26 Oct 2005 19:57:04 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: RELENG_6_0
Cc: 
Subject: cvs commit: src/sys/net if_vlan.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Oct 2005 19:57:05 -0000

pjd         2005-10-26 19:57:04 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_6_0)
    sys/net              if_vlan.c 
  Log:
  Call if_clone_detach() after vlan_clone_destroy() loop, as if_clone_detach()
  is freeing ifc_units field, which is used in
  vlan_clone_destroy()->ifc_free_unit().
  
  This fixes panic: ifc_free_unit: bit is already cleared
  
  The fix introduces a small race in that a new interface could be created
  between the vlan_clone_destroy() loop and the call to if_clone_detach().
  The race is probably too hard to trigger to be worry about it.
  
  This is not an MFC, because better fix was committed to HEAD.
  We decided to use this fix, as it is a low-risk fix, which fits just fine
  for 6.0 at this stage.
  
  Discussed with: brooks, thompsa
  Approved by:    re (scottl)
  
  Revision      Changes    Path
  1.79.2.4.2.1  +1 -1      src/sys/net/if_vlan.c