From nobody Mon Aug 18 15:10:24 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c5GNx0Htsz643Cw; Mon, 18 Aug 2025 15:10:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c5GNw6gPcz4CtZ; Mon, 18 Aug 2025 15:10:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755529824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xicWPiYhjOFsf6XOXAqHfTm04Wx3frQdlSqh1cirrzw=; b=x2cUd+v07DRboMv/iF/+VYJceQCZ/FOlmGPlWNx9Df4E0DXCv2/ORLVLRWBhxYXFjeYTOP KhGka4y9OZ+MngqCZ8XrURyvAQNuGDRcnwqgQ7Py4VCAIww6RyY0Udsn3xzt4LSx2goYPa m3+EBgkFHSvetq31SLiasElvTgMYcQs4E4EjW1gbnT8UlMwzkNFj8iYwjUteWKxec5q1+M cNgd3EutYVPOIXm6/WaCEyInG3DMlWn5lVulE1qm5fD95bkt5n1GWKIohUt32RDug0wd7r uT8iWE3Mt7m5pyRcWlgV5Ucb8I3oiZiy1YIwsuMeQj/mEmIYJ/jr6IPwjS0EHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755529824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xicWPiYhjOFsf6XOXAqHfTm04Wx3frQdlSqh1cirrzw=; b=fBiKLRabhoRPkDUaH4dMw144Ll9fGvkzuSeZVkALxXo29uLxv7f+ESOjxpaKKLWsDLI9DT C9Ib6WiWBJwcxJ/hD+DF5U6Gwc+l0S5cXfNyknk+A4mHxcQXFBtN+BGV0gZM/puhyRTQeT Nek42zP2kgPO/2XJl05zKS8EMyzfc7IlcC/Wc5UPz0P4/5Crb249yTs6jAXCS1hT6w4jbF TzSfFXwUgsFOsGXUkmpVW9bMVCZJjgdXi1ojJ8CG0h5KPB1+Y7gTxlChsX29kyiKuVEhGZ nTyM5R1vzLI3o3x0WQiHQPems/aAwmRbLzEvV6BSEwMfXR4URZGjo1kGXiy4kA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755529824; a=rsa-sha256; cv=none; b=Lk7mAYLpxsePc8F+O6Q8VDqGjyVLUWBbg0dOgWZYtQ26v2hqDRGDqmBWhZrgaNYi1XfwM7 6igLm/pyw7Ye+ZxSSkznc3wHDnMobV1JrZpPMzEzDTesZBrVfoHluLZzMZo7rsshdyK7ul 3F1aGVGpmeRQlBQcNyJLNoptqCAQ82kCu5+2KVJrukPuB0Xa4cX4iF6/4iEvFAzOgg/aOR JmHHku/nxnecP/ESMD6wOL7SEt2lz4Mfz0qq/su1lcH0LPDa5j0ST3h2wzlqPQgdRbPHG5 91XFWR3r5zT2dFADi33Z43nV0paqBbDpjzDvKfN4eHWmuc3B1OkcQY3IXO+Gsg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4c5GNw61Qfz11y2; Mon, 18 Aug 2025 15:10:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57IFAORp034334; Mon, 18 Aug 2025 15:10:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57IFAOG9034331; Mon, 18 Aug 2025 15:10:24 GMT (envelope-from git) Date: Mon, 18 Aug 2025 15:10:24 GMT Message-Id: <202508181510.57IFAOG9034331@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 47785e6a39cd - main - syslogd: EAGAIN and ECONNREFUSED are not permanently fatal List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 47785e6a39cdcbf4eb7d02c381a53916774ed991 Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=47785e6a39cdcbf4eb7d02c381a53916774ed991 commit 47785e6a39cdcbf4eb7d02c381a53916774ed991 Author: Kristof Provost AuthorDate: 2025-08-18 09:52:04 +0000 Commit: Kristof Provost CommitDate: 2025-08-18 15:10:01 +0000 syslogd: EAGAIN and ECONNREFUSED are not permanently fatal When we're forwarding syslog messages to a remote host we can get temporary failures such as EAGAIN or ECONNREFUSED from the sendmsg() call. These are not fatal. Future attempts to send might succeed. Don't mark the remote target as F_UNUSED so we'll try to log again on future messages. While here remove the commented out ENOBUFS case, because we actually handle that (by ignoring it, so we retry with future logs). Reviewed by: markj, jfree Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D51995 --- usr.sbin/syslogd/syslogd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/usr.sbin/syslogd/syslogd.c b/usr.sbin/syslogd/syslogd.c index fe7427130b78..81bbbbe66be8 100644 --- a/usr.sbin/syslogd/syslogd.c +++ b/usr.sbin/syslogd/syslogd.c @@ -1830,15 +1830,14 @@ fprintlog_write(struct filed *f, struct iovlist *il, int flags) case EHOSTUNREACH: case EHOSTDOWN: case EADDRNOTAVAIL: + case EAGAIN: + case ECONNREFUSED: break; /* case EBADF: */ /* case EACCES: */ /* case ENOTSOCK: */ /* case EFAULT: */ /* case EMSGSIZE: */ - /* case EAGAIN: */ - /* case ENOBUFS: */ - /* case ECONNREFUSED: */ default: dprintf("removing entry: errno=%d\n", e); f->f_type = F_UNUSED;