From nobody Thu Aug 6 07:41:01 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hFzjT4Zj8z6p2HJ for ; Thu, 06 Aug 2026 07:41:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hFzjT2Jftz3G0D for ; Thu, 06 Aug 2026 07:41:01 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786002061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WX5OaLlvKLdLqfEymvEotWRnH8zWPdZdsfjo5BU8qSY=; b=r/ZCbXTYnNhQhgsLlxPw2XLnLvM9smUU7SJzNzUCqJrVwUl5VFF7+Y8d2AK3Y/WnvwnTgh gJCya1SW5tt2r64gQIgPAiYbPcYC0rbwKydQvJujftqYxXj4ah9FkBiKqrTiWAkYP0dIaf IV6xYp4g+8FyjAcyJEYh44TVgVWZgJr+yZGjyZPDkbCHFkr1PbbH3Fz8HXNhpsxY4M0WmD a3LxlvFgzdg950dus+D8TFJVBTD5FZzqDdvv3yIfXKjYj0bDJaI82tZuyAybu9J6ROTvpM 3KPkUzJs8DFrPGMjbQXnsKWxVnZka1/aneh2XuHasT7Fj8miZbdYnYn0PTJqyg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786002061; a=rsa-sha256; cv=none; b=APR2VAvhDvXrGRGzXCw1MCJsXrGE5bqWqwWUXRdLoOToQH2/B8RqDxdIJlTaEeXyhA9qf6 9YeursM/wXkA7Deq39TG+TsSjvuLcFEK+p9Ki0IWWK90yNc1nxXygPXWo8R7sN3FyNVSDU lrC9zKQevu3IVuwoTk1JEz9pzXZYQ8F1i/uqQc27bX7ACLwbif0bHumjPwr4i6XnW/irWc 7abw4DKWl7ZCWK1jM7pcmptx1qbBINn0DatPJqFNqFRKPfdrlSnv/jZKvOUdjq4zweF5es 54TJPI7X2SdgkAroAXAahaPtOfwfuJSeuLG0jUMI+AdZTBwoDu5jZbpAfqNuug== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786002061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WX5OaLlvKLdLqfEymvEotWRnH8zWPdZdsfjo5BU8qSY=; b=Tl17G9Khs7nXkCsbxMJ13B5XJjNpYPJTZ7Vjnugjw8yfZ14O8j6OVjB9zBkDqngZy68OsK UCBE9y8EHg4K41Q3hoVEAni39WQNf1gkQdmDNndC8iyHT0poXfwqfnmZ5XAc+bz8tUxQgm qgRFZNXkvTBQobUonmtxjwxQ7DGHX6LfcDoXFIzbguFGPIgJq2g/hlo4xwyhbuhLBIeVEO 2FB2jrqiDarBp37IdhNeHuk8bXJy1qgTBp4i/qTD3P3M8MDErBy0okE0MsqNMra6sOzVb8 VaepvGGv4wm8eqFRmEjT83iZiDyPVcnPdJ+9kwvN2VOx7uegk3/ANAwnJTvPcw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hFzjT0qz6z19Cn for ; Thu, 06 Aug 2026 07:41:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 369df by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 06 Aug 2026 07:41:01 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 8ef5d8b48862 - stable/14 - igb: Reprogram descriptor queues while disabled List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 8ef5d8b48862dbee2728361aa2a71cc8fdb81f7d Auto-Submitted: auto-generated Date: Thu, 06 Aug 2026 07:41:01 +0000 Message-Id: <6a743a8d.369df.78b6863a@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=8ef5d8b48862dbee2728361aa2a71cc8fdb81f7d commit 8ef5d8b48862dbee2728361aa2a71cc8fdb81f7d Author: Kevin Bowling AuthorDate: 2026-07-30 04:37:08 +0000 Commit: Kevin Bowling CommitDate: 2026-08-06 07:40:33 +0000 igb: Reprogram descriptor queues while disabled Disable each igb-class transmit and receive queue and flush before changing its descriptor-ring registers. Restore the head and tail indices that Intel documents as surviving a VF reset. Use the igb queue-enable control instead of programming legacy TXDCTL granularity, low-water, and reserved bits that do not belong to the 82575 and later. Sponsored by: BBOX.io (cherry picked from commit f879d1cd7df3c5afa69428cc2b07e1675d7776c9) --- sys/dev/e1000/if_em.c | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index d19de710ae2c..1358139e2e20 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -3690,7 +3690,14 @@ em_initialize_transmit_unit(if_ctx_t ctx) /* Clear checksum offload context. */ offp = (caddr_t)&txr->csum_flags; endp = (caddr_t)(txr + 1); - bzero(offp, endp - offp); + memset(offp, 0, endp - offp); + + if (hw->mac.type >= igb_mac_min) { + txdctl = E1000_READ_REG(hw, E1000_TXDCTL(i)); + E1000_WRITE_REG(hw, E1000_TXDCTL(i), + txdctl & ~E1000_TXDCTL_QUEUE_ENABLE); + E1000_WRITE_FLUSH(hw); + } /* Base and Len of TX Ring */ E1000_WRITE_REG(hw, E1000_TDLEN(i), @@ -3709,9 +3716,12 @@ em_initialize_transmit_unit(if_ctx_t ctx) txdctl |= 0x1f; /* PTHRESH */ txdctl |= 1 << 8; /* HTHRESH */ txdctl |= 1 << 16;/* WTHRESH */ - txdctl |= 1 << 22; /* Reserved bit 22 must always be 1 */ - txdctl |= E1000_TXDCTL_GRAN; - txdctl |= 1 << 25; /* LWTHRESH */ + if (hw->mac.type < igb_mac_min) { + txdctl |= 1 << 22; /* Reserved bit must always be 1 */ + txdctl |= E1000_TXDCTL_GRAN; + txdctl |= 1 << 25; /* LWTHRESH */ + } else + txdctl |= E1000_TXDCTL_QUEUE_ENABLE; E1000_WRITE_REG(hw, E1000_TXDCTL(i), txdctl); } @@ -4019,6 +4029,11 @@ em_initialize_receive_unit(if_ctx_t ctx) srrctl |= E1000_SRRCTL_DESCTYPE_ADV_ONEBUF; #endif + rxdctl = E1000_READ_REG(hw, E1000_RXDCTL(i)); + E1000_WRITE_REG(hw, E1000_RXDCTL(i), + rxdctl & ~E1000_RXDCTL_QUEUE_ENABLE); + E1000_WRITE_FLUSH(hw); + E1000_WRITE_REG(hw, E1000_RDLEN(i), scctx->isc_nrxd[0] * sizeof(struct e1000_rx_desc)); @@ -4026,9 +4041,10 @@ em_initialize_receive_unit(if_ctx_t ctx) (uint32_t)(bus_addr >> 32)); E1000_WRITE_REG(hw, E1000_RDBAL(i), (uint32_t)bus_addr); + E1000_WRITE_REG(hw, E1000_RDH(i), 0); + E1000_WRITE_REG(hw, E1000_RDT(i), 0); E1000_WRITE_REG(hw, E1000_SRRCTL(i), srrctl); /* Enable this Queue */ - rxdctl = E1000_READ_REG(hw, E1000_RXDCTL(i)); rxdctl |= E1000_RXDCTL_QUEUE_ENABLE; rxdctl &= 0xFFF00000; rxdctl |= IGB_RX_PTHRESH;