From owner-svn-src-all@FreeBSD.ORG Sun Feb 27 15:48:15 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DA89E106564A for ; Sun, 27 Feb 2011 15:48:14 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 8DD2F8FC14 for ; Sun, 27 Feb 2011 15:48:14 +0000 (UTC) Received: from outgoing.leidinger.net (p5B32E670.dip.t-dialin.net [91.50.230.112]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id CC2F784400D; Sun, 27 Feb 2011 16:30:32 +0100 (CET) Received: from webmail.leidinger.net (unknown [IPv6:fd73:10c7:2053:1::2:102]) by outgoing.leidinger.net (Postfix) with ESMTP id 97E802F25; Sun, 27 Feb 2011 16:30:29 +0100 (CET) Received: (from www@localhost) by webmail.leidinger.net (8.14.4/8.13.8/Submit) id p1RFUEuI064748; Sun, 27 Feb 2011 16:30:14 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from p5DD458EC.dip.t-dialin.net (p5DD458EC.dip.t-dialin.net [93.212.88.236]) by webmail.leidinger.net (Horde Framework) with HTTP; Sun, 27 Feb 2011 16:30:13 +0100 Message-ID: <20110227163013.67016iavb4r2trgo@webmail.leidinger.net> Date: Sun, 27 Feb 2011 16:30:13 +0100 From: Alexander Leidinger To: Joerg Sonnenberger References: <201102271228.p1RCS6qG087131@svn.freebsd.org> <20110227123058.GA9092@britannica.bec.de> <20110227141143.GA11874@owl.midgard.homeip.net> <20110227142910.GA13518@britannica.bec.de> In-Reply-To: <20110227142910.GA13518@britannica.bec.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.4) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: CC2F784400D.A43C7 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=1.351, required 6, autolearn=disabled, RDNS_NONE 1.27, TW_SV 0.08) X-EBL-MailScanner-SpamScore: s X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1299425436.77492@VPQizMNDahcBdd33w45+Xw X-EBL-Spam-Status: No Cc: svn-src-all@freebsd.org Subject: Re: svn commit: r219084 - in head: bin/test tools/regression/bin/test X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Feb 2011 15:48:16 -0000 Quoting Joerg Sonnenberger (from Sun, 27 Feb 2011 15:29:10 +0100): > On Sun, Feb 27, 2011 at 03:11:43PM +0100, Erik Trulsson wrote: >> On Sun, Feb 27, 2011 at 01:30:58PM +0100, Joerg Sonnenberger wrote: >> > On Sun, Feb 27, 2011 at 12:28:06PM +0000, Xin LI wrote: >> > > Author: delphij >> > > Date: Sun Feb 27 12:28:06 2011 >> > > New Revision: 219084 >> > > URL: http://svn.freebsd.org/changeset/base/219084 >> > > >> > > Log: >> > > Accept == as an alias of = which is a popular GNU extension. >> > >> > It is not a popular GNU extension. It is crap only bash supports. >> > Do you really want to encourage that? >> >> In what way is it 'crap', and in what way would adding support for it >> be a problem? > > It is completely redundant and inconsistent with pretty much every other > test(1) implementation. E.g. it isn't even supported by /bin/test from > coretutils. The very presence of this in various shell scripts is a > direct result of silently accepting it in bash, even in sh mode. This is > just further encouragement to legalize it. For your info, at work we got a script (for Solaris) which had a mix of = and == (and [ ] and [[ ]]) as a delivery of some software. Needless to say it didn't work as expected. I also think that adding support for == encourages bad scripts. Bye, Alexander. -- 10.0 times 0.1 is hardly ever 1.0. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137