From owner-svn-src-head@freebsd.org Fri Feb 19 19:17:27 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D6ECBAAE3E2; Fri, 19 Feb 2016 19:17:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B847113B8; Fri, 19 Feb 2016 19:17:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id B00A2B94A; Fri, 19 Feb 2016 14:17:26 -0500 (EST) From: John Baldwin To: Stefan Esser Cc: Stefan Esser , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r295760 - head/usr.sbin/pciconf Date: Fri, 19 Feb 2016 10:47:13 -0800 Message-ID: <2165203.hVWJOExbtP@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <56C6265F.4050101@freebsd.org> References: <201602181523.u1IFNQk8004338@repo.freebsd.org> <1865104.t06og7Ezta@ralph.baldwin.cx> <56C6265F.4050101@freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 19 Feb 2016 14:17:26 -0500 (EST) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2016 19:17:27 -0000 On Thursday, February 18, 2016 09:15:27 PM Stefan Esser wrote: > Am 18.02.2016 um 19:07 schrieb John Baldwin: > >> @@ -172,6 +175,7 @@ cap_pcix(int fd, struct pci_conf *p, uin > >> } > >> if ((p->pc_hdr & PCIM_HDRTYPE) == 1) > >> return; > >> + max_burst_read = 0; > >> switch (status & PCIXM_STATUS_MAX_READ) { > >> case PCIXM_STATUS_MAX_READ_512: > >> max_burst_read = 512; > > > > Compilers are simply not smart enough. :-P > > Well, clang-3.7.1 in -CURRENT is ... > > But both gcc-4.2.1 and gcc-4.8.5 warn about a possibly uninitialized > variable. > > I could have changed the last case selector into "default" to silence > the warning without need for an initializer before the switch statement, > but that would be too ugly and misleading. No, I think your current version is fine, was just lamenting the compilers. :) > >> Modified: head/usr.sbin/pciconf/pciconf.c > >> ============================================================================== > >> --- head/usr.sbin/pciconf/pciconf.c Thu Feb 18 15:12:52 2016 (r295759) > >> +++ head/usr.sbin/pciconf/pciconf.c Thu Feb 18 15:23:25 2016 (r295760) > >> @@ -913,7 +915,8 @@ parsesel(const char *str) > >> ep += 3; > >> i = 0; > >> do { > >> - selarr[i++] = strtoul(ep, &ep, 10); > >> + selarr[i++] = strtoul(ep, &eppos, 10); > >> + ep = eppos; > >> } while ((*ep == ':' || *ep == '.') && *++ep != '\0' && i < 4); > > > > This is now indented oddly (2 spaces instead of a tab?). > > Sorry, the pciconf sources do not comply with "style" and I'm to blame, > since I committed the initial version nearly 20 years ago ... > > But you are correct, I got even the wrong indentation wrong ;-) > > Thank you for the review and your comments, I'll commit a fixed version > now. Thanks, the indentation is just a minor nit. -- John Baldwin