Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 8 Dec 2020 10:44:44 -0600
From:      Jason Bacon <bacon4000@gmail.com>
To:        Kyle Evans <kevans@freebsd.org>, "Jason W. Bacon" <jwb@freebsd.org>
Cc:        ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r557295 - in head/sysutils/slurm-wlm: . files
Message-ID:  <e6376ef8-0559-5f1e-eb5f-fb8414a991e3@gmail.com>
In-Reply-To: <CACNAnaHhC5bKgQUpOT0vgbd%2BXbd%2BXSx528Yyuh9mvDfy4Gmuow@mail.gmail.com>
References:  <202012081621.0B8GLGu7011665@repo.freebsd.org> <CACNAnaHhC5bKgQUpOT0vgbd%2BXbd%2BXSx528Yyuh9mvDfy4Gmuow@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 12/8/20 10:28 AM, Kyle Evans wrote:
> On Tue, Dec 8, 2020 at 10:21 AM Jason W. Bacon <jwb@freebsd.org> wrote:=

>> Author: jwb
>> Date: Tue Dec  8 16:21:16 2020
>> New Revision: 557295
>> URL: https://svnweb.freebsd.org/changeset/ports/557295
>>
>> Log:
>>    sysutils/slurm-wlm: Back out -fno-common patches, add -fcommon flag=

>>
>>    Fixes runtime regression caused by r546150
>>
>>    Reported by:    jrm
>>    MFH:            2020Q4
>>
> I guess the regression was from the patch to
> src/plugins/select/cons_tres/job_test.c and an issue somewhere without
> slurmctld? That patch almost certainly should have made them weak
> references instead of removing them entirely, based on the comment in
> the vicinity.
>
> Thanks,
>
> Kyle Evans
It's more complicated than that.=C2=A0 I tried converting to weak refs, b=
ut=20
the files are linked into multiple executables + the use of dlopen might =

obscure things to the compiler/linker.=C2=A0 I'd have to review the rules=
 to=20
verify the latter.

I'll see if upstream has made -fcommon unnecessary in the next release=20
when I have time to work on an upgrade a few weeks out.

Best,

 =C2=A0=C2=A0=C2=A0 JB

--=20
Earth is a beta site.





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e6376ef8-0559-5f1e-eb5f-fb8414a991e3>