From owner-freebsd-net@freebsd.org  Fri Dec  1 13:37:13 2017
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1F061E56400
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Fri,  1 Dec 2017 13:37:13 +0000 (UTC) (envelope-from sd@mostnet.ru)
Received: from mail.rlan.ru (mail.rlan.ru [213.234.25.10])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id CE05D288C
 for <freebsd-net@freebsd.org>; Fri,  1 Dec 2017 13:37:12 +0000 (UTC)
 (envelope-from sd@mostnet.ru)
Subject: Re: ng_patch is broken in 10.4-RELEASE
To: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>
References: <502ae893-1b55-305d-f1c4-de7f22159a15@mostnet.ru>
 <5A213E1A.2080805@grosbein.net>
From: Dmitry Selivanov <sd@mostnet.ru>
Message-ID: <d59a7ed4-6782-f3e2-745e-83bf29d16a8c@mostnet.ru>
Date: Fri, 1 Dec 2017 16:37:09 +0300
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <5A213E1A.2080805@grosbein.net>
Content-Type: text/plain; charset=koi8-r; format=flowed
Content-Language: ru
Content-Transfer-Encoding: 8bit
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Dec 2017 13:37:13 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224019

01.12.2017 14:33, Eugene Grosbein пишет:
> On 01.12.2017 16:39, Dmitry Selivanov wrote:
>> #ngctl mkpeer ipfw: patch 7 in
>> #ngctl name ipfw:7 tcp_rst
>> #ngctl connect ipfw: tcp_rst: 8 out
>> #ngctl msg tcp_rst: setconfig { count=1 csum_flags=0 ops=[ { mode=8 value=4 length=1 offset=33 } ] }
>> ngctl: send msg: Argument list too long
>>
>> It's broken after r309389 and could be fixed in r309408, but the first one went to 10.4 and the second one didn't.
>>
>> 11.0 didn't get this patches, 11.1 got both, so they are OK.
>>
>> Patch to fix:
>> --- /sys/netgraph/ng_patch.h.orig	2017-11-23 14:19:54.019040000 +0300
>> +++ /sys/netgraph/ng_patch.h	2017-11-30 15:34:23.000000000 +0300
>> @@ -80,7 +80,7 @@
>>
>>    struct ng_patch_config {
>>    	uint32_t	count;
>> -	uint32_t	csum_flags;
>> +	uint64_t	csum_flags;
>>    	struct ng_patch_op ops[];
>>    };
>>
>>
>> In this patch new uint64_t type is utilized. Instead this you can get back modified "csum_flags" to ng_parse_uint32_type in NG_PATCH_CONFIG_TYPE_INFO, which was changed in r309389.
>> Patch and rebuild ng_patch module.
> 
> А можно всё то же самое оформить в виде PR в http://bugs.freebsd.org/ и прислать мне ссылку? Займусь.
>