From owner-freebsd-emulation@FreeBSD.ORG Wed Jan 26 21:55:07 2011 Return-Path: Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BBA83106566B; Wed, 26 Jan 2011 21:55:07 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.cksoft.de (mail.cksoft.de [IPv6:2001:4068:10::3]) by mx1.freebsd.org (Postfix) with ESMTP id 40BB08FC0C; Wed, 26 Jan 2011 21:55:07 +0000 (UTC) Received: from localhost (amavis.fra.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 4450341C798; Wed, 26 Jan 2011 22:55:06 +0100 (CET) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([192.168.74.103]) by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id EWL8XKftWEY7; Wed, 26 Jan 2011 22:55:05 +0100 (CET) Received: by mail.cksoft.de (Postfix, from userid 66) id AE4EB41C7A9; Wed, 26 Jan 2011 22:55:05 +0100 (CET) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 4354B4448F3; Wed, 26 Jan 2011 21:51:18 +0000 (UTC) Date: Wed, 26 Jan 2011 21:51:18 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Mikolaj Golub In-Reply-To: <86ei7z4aps.fsf@kopusha.home.net> Message-ID: <20110126215009.T39951@maildrop.int.zabbadoz.net> References: <86oc77heqk.fsf@kopusha.home.net> <4D3D2DE9.2060004@freebsd.org> <86tygwy9p0.fsf@kopusha.home.net> <20110126091038.C3489@maildrop.int.zabbadoz.net> <86aainkbhb.fsf@zhuzha.ua1> <20110126141636.D3489@maildrop.int.zabbadoz.net> <86ei7z4aps.fsf@kopusha.home.net> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-emulation@freebsd.org, FreeBSD virtualization mailing list Subject: Re: VirtualBox + VIMAGE X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jan 2011 21:55:07 -0000 On Wed, 26 Jan 2011, Mikolaj Golub wrote: > > On Wed, 26 Jan 2011 14:18:03 +0000 (UTC) Bjoern A. Zeeb wrote: > > BAZ> On Wed, 26 Jan 2011, Mikolaj Golub wrote: > > >> > >> On Wed, 26 Jan 2011 09:15:46 +0000 (UTC) Bjoern A. Zeeb wrote: > >> > >> BAZ> I think you should wrap the CURVNET changes in __FreeBSD_version > >> BAZ> checks so that the port, should it run elsewhere or on older FreeBSDs > >> BAZ> (if it runs there) not trouble people having to patch it away. > >> > >> BAZ> #if defined(__FreeBSD_version) && __FreeBSD_version >= 800500 > >> BAZ> #endif > >> > >> BAZ> might be a save bet. > >> > >> Thanks. Something like in the patch below? > >> > >> Note, I have not run this version yet. Will test it tonight or tomorrow. > > BAZ> Well, you will need to include as well, and that only if > BAZ> you are on FreeBSD so you'll need an extra check for just that I > BAZ> guess. Not sure how vbox handles the all this in their guts. > > The file has already had '#include ' among other includes. It > just is not seen in the patch. The file is used only for FreeBSD driver so > there is no need in extra check I think. Ok, if it's freebsd only, then what you had was fine. > I have tested this latest version of the patch. It works for me. Cool. Thanks! -- Bjoern A. Zeeb You have to have visions! Going to jail sucks -- All my daemons like it! http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/jails.html