From owner-cvs-all@FreeBSD.ORG Sat Jun 25 20:07:01 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EAD8C16A41C; Sat, 25 Jun 2005 20:07:01 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd4mo1so.prod.shaw.ca (shawidc-mo1.cg.shawcable.net [24.71.223.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id B945D43D49; Sat, 25 Jun 2005 20:07:01 +0000 (GMT) (envelope-from cperciva@freebsd.org) Received: from pd2mr1so.prod.shaw.ca (pd2mr1so-qfe3.prod.shaw.ca [10.0.141.110]) by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0IIN003QUP4XC260@l-daemon>; Sat, 25 Jun 2005 14:05:21 -0600 (MDT) Received: from pn2ml10so.prod.shaw.ca ([10.0.121.80]) by pd2mr1so.prod.shaw.ca (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004)) with ESMTP id <0IIN009B8P3VBRB0@pd2mr1so.prod.shaw.ca>; Sat, 25 Jun 2005 14:04:43 -0600 (MDT) Received: from [192.168.0.60] (S0106006067227a4a.vc.shawcable.net [24.87.209.6]) by l-daemon (iPlanet Messaging Server 5.2 HotFix 1.18 (built Jul 28 2003)) with ESMTP id <0IIN00E66P3Q7Y@l-daemon>; Sat, 25 Jun 2005 14:04:43 -0600 (MDT) Date: Sat, 25 Jun 2005 13:04:09 -0700 From: Colin Percival In-reply-to: <200506251958.j5PJwIhq054393@grunt.grondar.org> To: Mark Murray Message-id: <42BDB8B9.8020400@freebsd.org> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Accept-Language: en-us, en X-Enigmail-Version: 0.91.0.0 References: <200506251958.j5PJwIhq054393@grunt.grondar.org> User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050406) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libmd Makefile sha256.3 sha256.h sha256c.c shadriver.c src/sbin/md5 Makefile md5.c src/sys/sys param.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jun 2005 20:07:02 -0000 Mark Murray wrote: > Colin Percival writes: >> MFC the addition of sha256 to libmd and md5(1). > > I still object to the use of "manufactured" 64-bit quantities > instead of using uint64_t, and less strongly to the re-engineering > of endianness code when we already have functional library routines > to do the job. Changing that is on my TODO list, but several people were asking me to MFC sha256, so I decided to do the MFC now and then MFC other changes later. Colin Percival