From owner-dev-commits-src-main@freebsd.org Sat Apr 10 15:18:29 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D0D925CF25D for ; Sat, 10 Apr 2021 15:18:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FHdtY5JG3z3h3D for ; Sat, 10 Apr 2021 15:18:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x734.google.com with SMTP id y5so8918994qkl.9 for ; Sat, 10 Apr 2021 08:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZVeIIpQlvReYXs7JaR6DHcuTODBRDiQMCM3ScSmW85o=; b=iLBZtT+xRgvVwsxzOxkTOkxCkXarDz8kAlbj/J9BR+OLMEEx3vh4acbHpkDlz3ghvi FYSEh//wkLcSmHa/2YnAzcqB8sNvuZlWQVj5Z7l7l0+WxQtwmLJmCtaiMLjx6rj3aXDu JtVGThYhY9thOAp0SLO6bkOzp9eSnQMEeFvB9QXZFabaLi0BPwgDL3ETUB1dzIzcLmTS CFn7ZadG07hIqTZPcU4nagvLV1CtsHOTwvfLptzdUz/GwuJXJKeZyiLmuOQdsQNeYdaM VKqSkfixnPScyH5lgG9zGxi8JNYgsfIIF7E34C2nsWR3bhouLGSdcOSHj/CMlU1kfHi8 xaTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZVeIIpQlvReYXs7JaR6DHcuTODBRDiQMCM3ScSmW85o=; b=oZy77Q7PXvpnWoNsRyAqv6K3ulRGmX8ejUTBfHJC3gTUQXmHGOxWXnxui6IZeQhguE HfRVC7fwcU8NPGgYC8gUM0xpBeaXRH21WXFnh6rtFzs5tT98JLbwNvR2rvO9jisZia1g wDTpg8uP1l9SJoX81XLd99qkpZ+QAo6gyzpX0OEzZEQb5LBFiJ8phhZ7mNLx6xzgngBI 8NLBr6YtSe9lx5Bu4UKE8s9tAynNUpIiKgD6KM+oQa8b8BEcHHcrxH3Fa4rYNHJui9z+ 240eEyGJoCIF64y5qjYRsmuxG2fupCjQq9EA9VCZUyW7GDLkDAy21fTGnSHG4D7okmpC ifIw== X-Gm-Message-State: AOAM533oW7nH+CZnPxw+sBPg7E1R/4VducrGhAzoPd13skMRaTM6Gf+m yQcHE/IXK6nkfP+5bHdQp9Ai39lb8oCbeDKoVrXZhA== X-Google-Smtp-Source: ABdhPJyfMRyeTIfQmIc+nsUrh4R8y2fpSADwcVM0XrSmxhNlte4+G6bMaMjfs3Rs/E/ckRjczQLnEDku9gNY00Fw8EE= X-Received: by 2002:a37:611:: with SMTP id 17mr5288281qkg.206.1618067908496; Sat, 10 Apr 2021 08:18:28 -0700 (PDT) MIME-Version: 1.0 References: <202104100832.13A8WiAg015126@gitrepo.freebsd.org> <20210410162324.343d3624@FreeBSD.org> In-Reply-To: <20210410162324.343d3624@FreeBSD.org> From: Warner Losh Date: Sat, 10 Apr 2021 09:18:16 -0600 Message-ID: Subject: Re: git: 44f3b1aa980e - main - rc: kldxref only needs to depend on rootfs, not FILESYSTEMS To: =?UTF-8?Q?T=C4=B3l_Coosemans?= Cc: Edward Tomasz Napierala , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4FHdtY5JG3z3h3D X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Apr 2021 15:18:29 -0000 On Sat, Apr 10, 2021, 8:23 AM T=C4=B3l Coosemans wrote: > On Sat, 10 Apr 2021 08:32:44 GMT Edward Tomasz Napierala > wrote: > > The branch main has been updated by trasz: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D44f3b1aa980e747ce9b72ba4333c80a= 99d8cd966 > > > > commit 44f3b1aa980e747ce9b72ba4333c80a99d8cd966 > > Author: Edward Tomasz Napierala > > AuthorDate: 2021-04-10 08:19:25 +0000 > > Commit: Edward Tomasz Napierala > > CommitDate: 2021-04-10 08:31:12 +0000 > > > > rc: kldxref only needs to depend on rootfs, not FILESYSTEMS > > > > This makes it run a bit earlier in the startup, which will > > be useful for the linux rc script later on. > > > > Reviewed By: imp (earlier version) > > Sponsored By: EPSRC > > Differential Revision: https://reviews.freebsd.org/D29589 > > --- > > libexec/rc/rc.d/kldxref | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libexec/rc/rc.d/kldxref b/libexec/rc/rc.d/kldxref > > index 4d232ee0d4cf..4c1fa15f2a35 100755 > > --- a/libexec/rc/rc.d/kldxref > > +++ b/libexec/rc/rc.d/kldxref > > @@ -4,7 +4,7 @@ > > # > > > > # PROVIDE: kldxref > > -# REQUIRE: FILESYSTEMS > > +# REQUIRE: root > > # BEFORE: netif > > # KEYWORD: nojail > > > > kldxref is in /usr which may be a separate file system so this requires > at least mountcritlocal. > I'd forgotten that detail. Maybe we should move it there. Warner >