Date: Thu, 07 Apr 2022 18:10:42 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 263124] sys/x86/isa/clock.c: lapic_calibrate_timer() in cpu_initclocks() breaks compiling for non-SMP Message-ID: <bug-263124-227-NXE60nb8y3@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-263124-227@https.bugs.freebsd.org/bugzilla/> References: <bug-263124-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263124 John Baldwin <jhb@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jhb@FreeBSD.org, | |markj@FreeBSD.org --- Comment #1 from John Baldwin <jhb@FreeBSD.org> --- Probably the code in clock.c needs to be conditional on DEV_APIC (device ap= ic on i386 sets this, and it is always on for amd64). For your system you really want 'device apic' I suspect even if you don't w= ant 'options SMP' as you get less IRQ sharing when using an I/O APIC in place of the old 8259A PICs even on a UP system. Also, at this point removing 'options SMP' doesn't really buy you anything = as we always compile the LOCK prefix in for atomic operations now. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-263124-227-NXE60nb8y3>