Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 26 Nov 2022 16:14:03 +0000
From:      Nuno Teixeira <eduardo@freebsd.org>
To:        Jan Beich <jbeich@freebsd.org>
Cc:        FreeBSD Mailing List <freebsd-ports@freebsd.org>
Subject:   Re: [zstd-sys 2.0.1+zstd.1.5.2] crate failing on arm64
Message-ID:  <CAFDf7UL-bNKgne4ooprW1Y4LP7r_aH_z%2BocY3ADqZXMgSboQUw@mail.gmail.com>
In-Reply-To: <pmd9-lq71-wny@FreeBSD.org>
References:  <CAFDf7UKTQmu3mnULC_716dgSUik2eKF4tOo7_y1YFsr98CREAw@mail.gmail.com> <pmd9-lq71-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000dc49c805ee61edc6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello Jan,

"if #[cfg(all(target_os =3D "freebsd", target_arch =3D "aarch64"" seems to =
be
the best bet to fix build.

I'm waiting for rust package 1.65.0 lands on 131aarch64 so I be able to
test it on poudriere/qemu.

Thanks,

Jan Beich <jbeich@freebsd.org> escreveu no dia s=C3=A1bado, 26/11/2022 =C3=
=A0(s)
14:56:

> Nuno Teixeira <eduardo@freebsd.org> writes:
>
> > From the log it seems [zstd-sys 2.0.1+zstd.1.5.2] crate failing.
>
> Unlikely if it shows up after "warning: build failed, waiting for other
> jobs to finish..."
> due to MAKE_JOBS_NUMBER=3D2 in poudriere log.
>
> >
> https://pkg-status.freebsd.org/ampere2/data/main-arm64-default/pf323e9d40=
f68_s41be508d31/logs/lapce-0.2.4.log
> [...]
> > [io-lifetimes 0.7.3] error[E0554]: `#![feature]` may not be used on the
> stable release channel
> > [io-lifetimes 0.7.3]  --> <anon>:1:1
> > [io-lifetimes 0.7.3]   |
> > [io-lifetimes 0.7.3] 1 | #![feature(rustc_attrs)]
> > [io-lifetimes 0.7.3]   | ^^^^^^^^^^^^^^^^^^^^^^^^
> > [io-lifetimes 0.7.3]
> > [io-lifetimes 0.7.3] error: aborting due to previous error
>
> Such errors don't abort build and also show up on amd64. If those ever
> become a problem check if adding CARGO_ENV+=3DRUSTC_BOOTSTRAP=3D1 helps.
>
> > error: unsupported platform
> >    -->
> /wrkdirs/usr/ports/editors/lapce/work/lapce-0.2.4/cargo-crates/wasmtime-r=
untime-1.0.2/src/traphandlers/
> unix.rs:232:13
> >     |
> > 232 |             compile_error!("unsupported platform");
> >     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >
> > error[E0308]: mismatched types
> >    -->
> /wrkdirs/usr/ports/editors/lapce/work/lapce-0.2.4/cargo-crates/wasmtime-r=
untime-1.0.2/src/traphandlers/
> unix.rs:167:73
> >     |
> > 167 | unsafe fn get_pc_and_fp(cx: *mut libc::c_void, _signum:
> libc::c_int) -> (*const u8, usize) {
> >     |           -------------
>      ^^^^^^^^^^^^^^^^^^ expected tuple, found `()`
> >     |           |
> >     |           implicitly returns `()` as its body has no tail or
> `return` expression
> >     |
> >     =3D note:  expected tuple `(*const u8, usize)`
> >             found unit type `()`
> >
> > For more information about this error, try `rustc --explain E0308`.
> > error: could not compile `wasmtime-runtime` due to 2 previous errors
>
> Looks like
> https://github.com/bytecodealliance/wasmtime/blob/main/crates/runtime/src=
/traphandlers/unix.rs
> needs something like
> https://github.com/wasmerio/wasmer/blob/dcfdea76999a/lib/vm/src/trap/trap=
handlers.rs#L302-L304
>


--=20
Nuno Teixeira
FreeBSD Committer (ports)

--000000000000dc49c805ee61edc6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hello Jan,</div><div><br></div><div>&quot;<span class=
=3D"gmail-pl-k">if</span> #<span class=3D"gmail-pl-kos">[</span>cfg<span cl=
ass=3D"gmail-pl-kos">(</span>all<span class=3D"gmail-pl-kos">(</span>target=
_os =3D <span class=3D"gmail-pl-s">&quot;freebsd&quot;</span>, target_arch =
=3D <span class=3D"gmail-pl-s">&quot;aarch64&quot;&quot; seems to be the be=
st bet to fix build.<br><br></span></div><div><span class=3D"gmail-pl-s">I&=
#39;m waiting for rust package 1.65.0 lands on 131aarch64 so I be able to t=
est it on poudriere/qemu.</span></div><div><span class=3D"gmail-pl-s"><br><=
/span></div><div><span class=3D"gmail-pl-s">Thanks,<br></span></div></div><=
br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">Jan Bei=
ch &lt;<a href=3D"mailto:jbeich@freebsd.org">jbeich@freebsd.org</a>&gt; esc=
reveu no dia s=C3=A1bado, 26/11/2022 =C3=A0(s) 14:56:<br></div><blockquote =
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px sol=
id rgb(204,204,204);padding-left:1ex">Nuno Teixeira &lt;<a href=3D"mailto:e=
duardo@freebsd.org" target=3D"_blank">eduardo@freebsd.org</a>&gt; writes:<b=
r>
<br>
&gt; From the log it seems [zstd-sys 2.0.1+zstd.1.5.2] crate failing.<br>
<br>
Unlikely if it shows up after &quot;warning: build failed, waiting for othe=
r jobs to finish...&quot;<br>
due to MAKE_JOBS_NUMBER=3D2 in poudriere log.<br>
<br>
&gt; <a href=3D"https://pkg-status.freebsd.org/ampere2/data/main-arm64-defa=
ult/pf323e9d40f68_s41be508d31/logs/lapce-0.2.4.log" rel=3D"noreferrer" targ=
et=3D"_blank">https://pkg-status.freebsd.org/ampere2/data/main-arm64-defaul=
t/pf323e9d40f68_s41be508d31/logs/lapce-0.2.4.log</a><br>
[...]<br>
&gt; [io-lifetimes 0.7.3] error[E0554]: `#![feature]` may not be used on th=
e stable release channel<br>
&gt; [io-lifetimes 0.7.3]=C2=A0 --&gt; &lt;anon&gt;:1:1<br>
&gt; [io-lifetimes 0.7.3]=C2=A0 =C2=A0|<br>
&gt; [io-lifetimes 0.7.3] 1 | #![feature(rustc_attrs)]<br>
&gt; [io-lifetimes 0.7.3]=C2=A0 =C2=A0| ^^^^^^^^^^^^^^^^^^^^^^^^<br>
&gt; [io-lifetimes 0.7.3] <br>
&gt; [io-lifetimes 0.7.3] error: aborting due to previous error<br>
<br>
Such errors don&#39;t abort build and also show up on amd64. If those ever<=
br>
become a problem check if adding CARGO_ENV+=3DRUSTC_BOOTSTRAP=3D1 helps.<br=
>
<br>
&gt; error: unsupported platform<br>
&gt;=C2=A0 =C2=A0 --&gt; /wrkdirs/usr/ports/editors/lapce/work/lapce-0.2.4/=
cargo-crates/wasmtime-runtime-1.0.2/src/traphandlers/<a href=3D"http://unix=
.rs:232" target=3D"_blank">unix.rs:232</a>:13<br>
&gt;=C2=A0 =C2=A0 =C2=A0|<br>
&gt; 232 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0compile_error!(&q=
uot;unsupported platform&quot;);<br>
&gt;=C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^^=
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^<br>
&gt;<br>
&gt; error[E0308]: mismatched types<br>
&gt;=C2=A0 =C2=A0 --&gt; /wrkdirs/usr/ports/editors/lapce/work/lapce-0.2.4/=
cargo-crates/wasmtime-runtime-1.0.2/src/traphandlers/<a href=3D"http://unix=
.rs:167" target=3D"_blank">unix.rs:167</a>:73<br>
&gt;=C2=A0 =C2=A0 =C2=A0|<br>
&gt; 167 | unsafe fn get_pc_and_fp(cx: *mut libc::c_void, _signum: libc::c_=
int) -&gt; (*const u8, usize) {<br>
&gt;=C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0---------=
----=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^^^^^^^^^^^^^^^^^^ expected tuple, found `()=
`<br>
&gt;=C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|<br>
&gt;=C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0implicitl=
y returns `()` as its body has no tail or `return` expression<br>
&gt;=C2=A0 =C2=A0 =C2=A0|<br>
&gt;=C2=A0 =C2=A0 =C2=A0=3D note:=C2=A0 expected tuple `(*const u8, usize)`=
<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0found unit type `()`<br=
>
&gt;<br>
&gt; For more information about this error, try `rustc --explain E0308`.<br=
>
&gt; error: could not compile `wasmtime-runtime` due to 2 previous errors<b=
r>
<br>
Looks like <a href=3D"https://github.com/bytecodealliance/wasmtime/blob/mai=
n/crates/runtime/src/traphandlers/unix.rs" rel=3D"noreferrer" target=3D"_bl=
ank">https://github.com/bytecodealliance/wasmtime/blob/main/crates/runtime/=
src/traphandlers/unix.rs</a><br>
needs something like <a href=3D"https://github.com/wasmerio/wasmer/blob/dcf=
dea76999a/lib/vm/src/trap/traphandlers.rs#L302-L304" rel=3D"noreferrer" tar=
get=3D"_blank">https://github.com/wasmerio/wasmer/blob/dcfdea76999a/lib/vm/=
src/trap/traphandlers.rs#L302-L304</a><br>
</blockquote></div><br clear=3D"all"><br>-- <br><div dir=3D"ltr" class=3D"g=
mail_signature"><div dir=3D"ltr"><span style=3D"color:rgb(102,102,102)">Nun=
o Teixeira<br>FreeBSD Committer (ports)</span></div></div>

--000000000000dc49c805ee61edc6--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UL-bNKgne4ooprW1Y4LP7r_aH_z%2BocY3ADqZXMgSboQUw>