From owner-freebsd-bugs Thu May 9 08:17:23 1996 Return-Path: owner-bugs Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id IAA15140 for bugs-outgoing; Thu, 9 May 1996 08:17:23 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id IAA15076 Thu, 9 May 1996 08:16:29 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.12/8.6.9) id BAA32747; Fri, 10 May 1996 01:07:24 +1000 Date: Fri, 10 May 1996 01:07:24 +1000 From: Bruce Evans Message-Id: <199605091507.BAA32747@godzilla.zeta.org.au> To: j@ida.interface-business.de, phk@critter.tfs.com Subject: Re: kern/794 Cc: freebsd-bugs@freefall.freebsd.org, joerg_wunsch@interface-business.de, phk@freefall.freebsd.org Sender: owner-bugs@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >Thinking more about it... it's been wrong that it was even starting to >dump at offset 0. It should compute the required space backwards from >the end of the dump area. Now i wonder why it started at 0... (the >swap partition was large enough). I think _that's_ the real bug. The static configuration case is broken (setdumpdev() doesn't get called). Space near 0 can get clobbered if the partition just fits (0 <= partition_size - memory_size < 8K). Cases where the device containing the dump partition or the dump partition itself goes away are also broken. The system should at least hold a reference like it does for swapon(). Bruce