From owner-freebsd-current@FreeBSD.ORG Mon Dec 21 13:36:02 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3396B1065670; Mon, 21 Dec 2009 13:36:02 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 06DE38FC08; Mon, 21 Dec 2009 13:36:02 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id B2E8A46B39; Mon, 21 Dec 2009 08:36:01 -0500 (EST) Received: from jhbbsd.localnet (unknown [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id DFB428A01F; Mon, 21 Dec 2009 08:36:00 -0500 (EST) From: John Baldwin To: freebsd-current@freebsd.org Date: Fri, 18 Dec 2009 10:16:26 -0500 User-Agent: KMail/1.12.1 (FreeBSD/7.2-CBSD-20091103; KDE/4.3.1; amd64; ; ) References: <200912161721.53540.jhb@freebsd.org> <86ljh0bh7b.fsf@ds4.des.no> In-Reply-To: <86ljh0bh7b.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <200912181016.26573.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 21 Dec 2009 08:36:01 -0500 (EST) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Dag-Erling =?utf-8?q?Sm=C3=B8rgrav?= , Ivan Voras Subject: Re: NOTES checker X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Dec 2009 13:36:02 -0000 On Friday 18 December 2009 7:27:20 am Dag-Erling Sm=C3=B8rgrav wrote: > Ivan Voras writes: > > John Baldwin writes: > > > I wrote a little script today that crawls through sys/conf/files*, > > > sys/conf/options*, sys/conf/NOTES, and sys/*/conf/NOTES looking for d= evices > > > or options that are not tested in all the places they are valid. If = folks > > > are interested I can commit it to src/tools. At the moment we have 3= 00+ > > > violations in HEAD. :) The first few look like this: > > What does "tested" mean in this context? >=20 > IIUC, it means "listed in NOTES on all arches that it claims to run on". Yes. It means something like 'LINT builds will test this option'. > > > WARN: device acpi_aiboost is defined globally but only tested in i386= NOTES > > > WARN: device acpi_asus is defined globally but only tested in i386 NO= TES > > > WARN: device acpi_dock is defined globally but only tested in i386 NO= TES > > > WARN: device acpi_fujitsu is defined globally but only tested in i386= NOTES > > > WARN: device acpi_hp is defined globally but only tested in i386 NOTES > > > WARN: device acpi_ibm is defined globally but only tested in i386 NOT= ES > > > WARN: option ACPI_MAX_TASKS is defined globally but never tested > > > WARN: option ACPI_MAX_THREADS is defined globally but never tested > > > WARN: device acpi_panasonic is defined globally but only tested in i3= 86 NOTES > > > WARN: device acpi_sony is defined globally but only tested in i386 NO= TES > > > WARN: device acpi_toshiba is defined globally but only tested in i386= NOTES > > > WARN: device acpi_video is defined globally but only tested in i386 N= OTES > > > WARN: device acpi_wmi is defined globally but only tested in i386 NOT= ES >=20 > The bug here is not that they aren't tested outside i386, but that they > are defined globally (although some of them, perhaps even all, are also > valid on amd64) Yep. Either way it is still "buggy". =2D-=20 John Baldwin