From owner-svn-src-all@FreeBSD.ORG Thu Dec 18 21:58:23 2008 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3EEEF106564A; Thu, 18 Dec 2008 21:58:23 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from cmail.optima.ua (cmail.optima.ua [195.248.191.121]) by mx1.freebsd.org (Postfix) with ESMTP id 4F6EA8FC12; Thu, 18 Dec 2008 21:58:21 +0000 (UTC) (envelope-from mav@FreeBSD.org) X-Spam-Flag: SKIP X-Spam-Yversion: Spamooborona-2.1.0 Received: from [212.86.226.226] (account mav@alkar.net HELO mavbook.mavhome.dp.ua) by cmail.optima.ua (CommuniGate Pro SMTP 5.2.9) with ESMTPSA id 230126621; Thu, 18 Dec 2008 23:58:21 +0200 Message-ID: <494AC77A.5010609@FreeBSD.org> Date: Thu, 18 Dec 2008 23:58:18 +0200 From: Alexander Motin User-Agent: Thunderbird 2.0.0.17 (X11/20081029) MIME-Version: 1.0 To: Niclas Zeising References: <200812182113.mBILDkwt052441@svn.freebsd.org> <494AC475.20808@gmail.com> In-Reply-To: <494AC475.20808@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r186296 - head/sys/dev/ata/chipsets X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2008 21:58:23 -0000 Niclas Zeising wrote: > Alexander Motin wrote: >> Author: mav >> Date: Thu Dec 18 21:13:46 2008 >> New Revision: 186296 >> URL: http://svn.freebsd.org/changeset/base/186296 >> >> Log: >> Before modularization commit, atapci driver was attaching only to >> devices of >> storage class. This check was lost. It is not important for the most >> cases, >> but as it was reported on current@, it does important for sis driver >> and >> surely inportant for AHCI driver. So restore it there. >> Submitted by: Toshikazu ICHINOSEKI, Andrey V. Elsukov >> Discussed on: current@ >> >> --- head/sys/dev/ata/chipsets/ata-sis.c Thu Dec 18 21:04:50 2008 >> (r186295) >> +++ head/sys/dev/ata/chipsets/ata-sis.c Thu Dec 18 21:13:46 2008 >> (r186296) >> @@ -105,6 +105,9 @@ ata_sis_probe(device_t dev) >> char buffer[64]; >> int found = 0; >> >> + if (pci_get_class(dev) != PCIC_STORAGE) >> + return (ENXIO); >> + >> if (pci_get_vendor(dev) != ATA_SIS_ID) >> return ENXIO; > > With this change, am I able to boot from a harddrive located on a > SiS-controller again? Or is that more likely a different issue? > I have't investigated my issue properly due to lack of time, so I don't > know exactly what's wrong, only that it can't find the hard drive properly. I have no idea what your problem is, I am just a man. :) But if your problem appeared on 8-CURRENT about two months ago, then it may be it and so may be solved. -- Alexander Motin