From owner-p4-projects@FreeBSD.ORG  Thu Jul 12 16:18:10 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 7EC0B16A474; Thu, 12 Jul 2007 16:18:10 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 395F916A46D;
	Thu, 12 Jul 2007 16:18:10 +0000 (UTC)
	(envelope-from cnst@FreeBSD.org)
Received: from mojo.ru (mojo.ru [84.252.152.63])
	by mx1.freebsd.org (Postfix) with ESMTP id B02ED13C484;
	Thu, 12 Jul 2007 16:18:09 +0000 (UTC)
	(envelope-from cnst@FreeBSD.org)
Received: from [192.168.0.16] (nc-76-4-28-21.dhcp.embarqhsd.net [76.4.28.21])
	(authenticated bits=0)
	by mojo.ru (8.12.11.20060308/8.12.10) with ESMTP id l6CGI7GA005193
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 12 Jul 2007 20:18:11 +0400
Message-ID: <46965433.6050207@FreeBSD.org>
Date: Thu, 12 Jul 2007 12:17:55 -0400
From: "Constantine A. Murenin" <cnst@FreeBSD.org>
Organization: Google Summer of Code 2007 Student @ The FreeBSD Project
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB;
	rv:1.7.5) Gecko/20041217
X-Accept-Language: en-gb, en-gb-oed, en, en-us, ru, ru-ru, ru-su
MIME-Version: 1.0
To: Alexey Tarasov <taleks@FreeBSD.org>
References: <200707121428.l6CESBSj045007@repoman.freebsd.org>
In-Reply-To: <200707121428.l6CESBSj045007@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Shteryana Shopova <syrinx@FreeBSD.org>,
	Perforce Change Reviews <perforce@FreeBSD.org>,
	"Constantine A. Murenin" <cnst@FreeBSD.org>
Subject: Re: PERFORCE change 123376 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jul 2007 16:18:10 -0000

On 12/07/2007 10:28, Alexey Tarasov wrote:

> http://perforce.freebsd.org/chv.cgi?CH=123376
> 
> Change 123376 by taleks@taleks_th on 2007/07/12 14:27:18
> 

...

> @@ -104,11 +107,11 @@
>  	}
>  
>  	if ( (from == 0) && (size == 0) ) {
> -		sprintf(http_data, "GET /%s HTTP/1.1\r\nHost: %s\r\nConnection: Close\r\n\r\n",
> +		sprintf(http_data, "GET /%s HTTP/1.1\r\nHost: %s\r\nConnection: Close\r\nUser-Agent: pxe_http/0\r\n\r\n",
>  		    filename, server_name
>  		);
>  	} else {
> -		sprintf(http_data, "GET /%s HTTP/1.1\r\nHost: %s\r\nRange: %d-%d\r\nConnection: Close\r\n\r\n",
> +		sprintf(http_data, "GET /%s HTTP/1.1\r\nHost: %s\r\nRange: bytes=%d-%d\r\nConnection: Close\r\nUser-Agent: pxe_http/0\r\n\r\n",
>  		    filename, server_name, from, from + size
>  		);
>  	}

You might want to change long lines like these to something as follows:

	if ( (from == 0) && (size == 0) )
		sprintf(http_data, "GET /%s HTTP/1.1\r\nHost: %s\r\n"
		    "Connection: Close\r\nUser-Agent: pxe_http/0\r\n\r\n",
		    filename, server_name);
	else
		sprintf(http_data, "GET /%s HTTP/1.1\r\nHost: %s\r\n"
		    "Range: bytes=%d-%d\r\n"
		    "Connection: Close\r\nUser-Agent: pxe_http/0\r\n\r\n",
		    filename, server_name, from, from + size);

Also note that ");" should not appear on a line by itself, if I'm reading 
style(9) correctly.

Removing curly brackets is optional in this case, because lines are somewhat 
long, but personally, I do like them removed, too. :)

Cheers,
Constantine.