From nobody Tue Apr 14 19:47:41 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fwFDf5jJNz6ZKyp for ; Tue, 14 Apr 2026 19:47:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fwFDf2htMz42Fk for ; Tue, 14 Apr 2026 19:47:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776196066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WW+bgJ2MRnaEz49ko6fleZTDH18MT/p30ZNcn5qKKVo=; b=kMFETfNz/lm6WtiK123G3rCvICmXEw8kiEKCMX7rMnMGBZsrDBDkLAIggCjIX2uMKwMVGl 8dCu/zunH3F0JBlthXDavB3LePPo81aMIDdkKmb6AUR4CNR7y81iC5pHtU23FfrP+68cA4 ngC1vPX1Lxr7fMSH3BLDvOTikVxSIQTLW5x6CHsa0B4NOzLzK+EwUI55mLEZKoDeSVw9uO v4EmG1WbZNP4z2cCZTwKb9bX6a7q3UQ5lyE4NmKJH/UIaKshGIz0itE1NLfwS9Nx3S2wX4 jxfInFq0HegMKA4QYK0vMsY2t2POCUXESZHO/21AN1rr6DSkeJSR22/P7ewJWA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776196066; a=rsa-sha256; cv=none; b=vH1oEWNAyt8sUzkhxerbeHAaAwXuNDxIDq5QLRzxTffYI0cbhE9dNAJqHwZGoUDoau+kUG 6m3LDX7uYHM3os2K5zDO71ZZTXKl4GvYqiz0qS73XCQ9spM2eWWeg2TAN5fL2jqkwb6mkL z1EMgWqESdMxT8aTPFvbst9k6q63tA+1+lbj58ARP2FwhAPL5VykALMMLG3A3aPFZ1bXoy Jq92DT9w6xJMpzWqacM6BuOdLuKqyIb4jR1vHorxGt4E+fE3x56oSYIwwaEP3vv8tbp8D/ R7HyRsB4PhzzOd2t3I5AzIbQnEp97UUI9g5lnBRubn/sVwwS7XdqPChBxelqpw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776196066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WW+bgJ2MRnaEz49ko6fleZTDH18MT/p30ZNcn5qKKVo=; b=kdO+o4YnBrylZvjWGc8BhbnFM9iKWAjIbNX4xmqCmf29ZoaFWJIUqL32tI5Y116tHsfA4t AHsCktucGJtILD76CSS4qPKNreRGQIqvMfhErZkhdxZp7ZVhAJMKbB45L8poOtAHGOUl0L FizCP45Z3zeRz9AoblYO69PBo2Pc2TwE+dy7LQMUHFuQR+7Rw6TImISHQeNSJHbWIDSEaH 0rV0jmqqDVtrPMFAXMkrxdxDGVgDulDADb3AMofZdGp0ZRDypjy/C3jK8xeC/kG4gyDNaP LNLB08y9fx2ewplXvpCf8PZoIjiZEBNg7f5V4rO3NYWRQpLvp5gqHSEv5TsAnw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fwFDf1dQsz1493 for ; Tue, 14 Apr 2026 19:47:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 422ab by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 14 Apr 2026 19:47:41 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andrew Gallatin Subject: git: 956acdce0505 - main - loopback: Account for packet drops List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gallatin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 956acdce0505ca8028d287d3b44789c623c8f37e Auto-Submitted: auto-generated Date: Tue, 14 Apr 2026 19:47:41 +0000 Message-Id: <69de99dd.422ab.2b84d627@gitrepo.freebsd.org> The branch main has been updated by gallatin: URL: https://cgit.FreeBSD.org/src/commit/?id=956acdce0505ca8028d287d3b44789c623c8f37e commit 956acdce0505ca8028d287d3b44789c623c8f37e Author: Andrew Gallatin AuthorDate: 2026-04-14 19:43:28 +0000 Commit: Andrew Gallatin CommitDate: 2026-04-14 19:43:28 +0000 loopback: Account for packet drops Make loopback packet drops more obvious by reporting them in interface stats visable via netstat -ni Since loopback uses netisr, packets can be dropped if the netisr queue overflows. These drops are visible via netisr -Q, but its not an obvious place to look. Differential Revision: https://reviews.freebsd.org/D56356 Reviewed by: glebius, tuexen Sponsored by: Netflix --- sys/net/if_loop.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/sys/net/if_loop.c b/sys/net/if_loop.c index 37309260a0d3..2ff265d5d1e7 100644 --- a/sys/net/if_loop.c +++ b/sys/net/if_loop.c @@ -350,9 +350,13 @@ if_simloop(struct ifnet *ifp, struct mbuf *m, int af, int hlen) m_freem(m); return (EAFNOSUPPORT); } - if_inc_counter(ifp, IFCOUNTER_IPACKETS, 1); - if_inc_counter(ifp, IFCOUNTER_IBYTES, m->m_pkthdr.len); - netisr_queue(isr, m); /* mbuf is free'd on failure. */ + if (netisr_queue(isr, m) == 0) { + if_inc_counter(ifp, IFCOUNTER_IPACKETS, 1); + if_inc_counter(ifp, IFCOUNTER_IBYTES, m->m_pkthdr.len); + } else { + /* mbuf is free'd on failure. */ + if_inc_counter(ifp, IFCOUNTER_IQDROPS, 1); + } return (0); }