Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Jun 2025 15:30:35 GMT
From:      Kristof Provost <kp@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 1e4c562fdfb2 - main - pf: remove unused argument from pf_get_translation()
Message-ID:  <202506021530.552FUZF4049884@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=1e4c562fdfb211c6f23179dba3952757ed7b8ee3

commit 1e4c562fdfb211c6f23179dba3952757ed7b8ee3
Author:     Kristof Provost <kp@FreeBSD.org>
AuthorDate: 2025-06-02 08:23:43 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2025-06-02 15:30:18 +0000

    pf: remove unused argument from pf_get_translation()
    
    No functional change.
    
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
---
 sys/net/pfvar.h        | 2 +-
 sys/netpfil/pf/pf.c    | 2 +-
 sys/netpfil/pf/pf_lb.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sys/net/pfvar.h b/sys/net/pfvar.h
index b3e3260d80a6..c77744d55314 100644
--- a/sys/net/pfvar.h
+++ b/sys/net/pfvar.h
@@ -2739,7 +2739,7 @@ u_short			 pf_map_addr_sn(u_int8_t, struct pf_krule *,
 int			 pf_get_transaddr_af(struct pf_krule *,
 			    struct pf_pdesc *);
 u_short			 pf_get_translation(struct pf_pdesc *,
-			    int, struct pf_state_key **, struct pf_state_key **,
+			    struct pf_state_key **, struct pf_state_key **,
 			    struct pf_test_ctx *, struct pf_udp_mapping **udp_mapping);
 u_short			 pf_get_transaddr(struct pf_pdesc *,
 			    struct pf_state_key **, struct pf_state_key **,
diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c
index a5f51d69ab2b..7fb544460b02 100644
--- a/sys/netpfil/pf/pf.c
+++ b/sys/netpfil/pf/pf.c
@@ -5789,7 +5789,7 @@ pf_test_rule(struct pf_krule **rm, struct pf_kstate **sm,
 	pd->odport = pd->ndport;
 
 	/* check packet for BINAT/NAT/RDR */
-	transerror = pf_get_translation(pd, pd->off, &ctx.sk, &ctx.nk, &ctx,
+	transerror = pf_get_translation(pd, &ctx.sk, &ctx.nk, &ctx,
 	    &ctx.udp_mapping);
 	switch (transerror) {
 	default:
diff --git a/sys/netpfil/pf/pf_lb.c b/sys/netpfil/pf/pf_lb.c
index ed87aa2cec4d..697f680c97bf 100644
--- a/sys/netpfil/pf/pf_lb.c
+++ b/sys/netpfil/pf/pf_lb.c
@@ -843,7 +843,7 @@ done:
 }
 
 u_short
-pf_get_translation(struct pf_pdesc *pd, int off,
+pf_get_translation(struct pf_pdesc *pd,
     struct pf_state_key **skp, struct pf_state_key **nkp,
     struct pf_test_ctx *ctx, struct pf_udp_mapping **udp_mapping)
 {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202506021530.552FUZF4049884>