From owner-freebsd-current@FreeBSD.ORG Mon Apr 7 17:41:07 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2F0231065670 for ; Mon, 7 Apr 2008 17:41:07 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:610:652::211]) by mx1.freebsd.org (Postfix) with ESMTP id E527E8FC0A for ; Mon, 7 Apr 2008 17:41:06 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: by palm.hoeg.nl (Postfix, from userid 1000) id 82F271CC6D; Mon, 7 Apr 2008 19:40:49 +0200 (CEST) Date: Mon, 7 Apr 2008 19:40:49 +0200 From: Ed Schouten To: Giorgos Keramidas Message-ID: <20080407174049.GO5934@hoeg.nl> References: <47F95B6D.80006@quis.cx> <20080407083746.GL5934@hoeg.nl> <47FA0BC1.3010803@quis.cx> <87myo58tjz.fsf@kobe.laptop> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wr1Q/2bz0MCWWNYv" Content-Disposition: inline In-Reply-To: <87myo58tjz.fsf@kobe.laptop> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: FreeBSD Current , Jille Subject: Re: werase patch for src/contrib/top X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Apr 2008 17:41:07 -0000 --wr1Q/2bz0MCWWNYv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Giorgos Keramidas wrote: > On Mon, 07 Apr 2008 13:55:45 +0200, Jille wrote: > > Ed Schouten schreef: > > | * Jille Timmermans wrote: > > |> I've patched top (in src/contrib) to accept ^W in line editing mode = (eg > > |> when killing a process (hit 'k')) > > |> > > |> The patch is attached, and I hope mailman won't eat it, or else: > > |> http://junk.quis.cx/NbVJSKxn/top-werase-patch.diff > > |> there it is :) > > |> I took the RELENG_6 version, and editted that one. > > | > > | Apart from some style(9) issues, it looks great. Unfortunately the > > | top(8) source code is not maintained by FreeBSD. Its website seems to= be >=20 > Hi Ed, >=20 > The original contrib/top source doesn't really follow style(9); it has a > style of its own, so some of the changes look `good enough'. Can you > describe what you didn't like, so we can fix it before it's committed? I didn't like the missing whitespace between the operators. I just spoke with Jille on IRC. He has an updated patch: http://junk.quis.cx/ctfhENEs/top-werase-patch-styled.diff > > Hello Ed, > > After an hour of reading style(9), I've fixed my patch, thanks for > > pointing out. Unixtop seems to be on SourceForge now, so I will > > submit it to their patch-tracker. >=20 > It would be nice if we also committed something similar to our top, > since many top sources in src/contrib/top are already *off* the vendor > branch anyway :-) Yes please! I would like to see Jille's stuff end up in CVS. :-) --=20 Ed Schouten WWW: http://g-rave.nl/ --wr1Q/2bz0MCWWNYv Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEARECAAYFAkf6XKEACgkQ52SDGA2eCwWVZgCfcBvzDXXGIar8q1IjDQ6XZG4b Iy8An2NPZDp8O0AouzW/bYLQGq1PTZym =y4OQ -----END PGP SIGNATURE----- --wr1Q/2bz0MCWWNYv--