Date: Wed, 4 May 2022 17:30:13 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Baptiste Daroussin <bapt@freebsd.org> Cc: Emmanuel Vadot <manu@bidouilliste.com>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ecf09fe34600 - main - graphics/gpu-firmware*-kmod: disable amdgpu on powerpc64 Message-ID: <YnKcBYPJB3y8Lb%2Bq@KGPE-D16> In-Reply-To: <20220504151604.dxems72xwxhj3eig@aniel.nours.eu> References: <202205041257.244CvQYJ029723@gitrepo.freebsd.org> <20220504152200.5881461e1e927b155884fe4c@bidouilliste.com> <YnKOm%2BJMm4E1AHY%2B@KGPE-D16> <20220504151604.dxems72xwxhj3eig@aniel.nours.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
--Cnx07BzOhAcsa1xr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 22-05-04 17:16:04, Baptiste Daroussin wrote: > On Wed, May 04, 2022 at 04:32:59PM +0200, Piotr Kubaj wrote: > > On 22-05-04 15:22:00, Emmanuel Vadot wrote: > > > On Wed, 4 May 2022 12:57:26 GMT > > > Piotr Kubaj <pkubaj@FreeBSD.org> wrote: > > >=20 > > > > The branch main has been updated by pkubaj: > > > >=20 > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3Decf09fe3460067b442= ba41a6adb85897c99442b5 > > > >=20 > > > > commit ecf09fe3460067b442ba41a6adb85897c99442b5 > > > > Author: Piotr Kubaj <pkubaj@FreeBSD.org> > > > > AuthorDate: 2022-05-04 12:54:19 +0000 > > > > Commit: Piotr Kubaj <pkubaj@FreeBSD.org> > > > > CommitDate: 2022-05-04 12:54:19 +0000 > > > >=20 > > > > graphics/gpu-firmware*-kmod: disable amdgpu on powerpc64 > > > > =20 > > > > amdgpu has known endianness issues and doesn't work on powerpc6= 4. > > > > radeonkms works, while amdgpu works on powerpc64le. > > > > --- > > > > graphics/gpu-firmware-amd-kmod/Makefile | 4 +- > > > > graphics/gpu-firmware-kmod/Makefile | 67 +++++++++++++++++----= ------------ > > > > 2 files changed, 37 insertions(+), 34 deletions(-) > > > >=20 > > >=20 > > > Can you respect MAINTAINER and open a review next time ? > >=20 > > I believe this falls under tier 2 blanket. Correct me if I'm mistaken. >=20 > It somehow is and somehow isn't, basically the blanket for tier 2 is to c= ommit > trivial changes which allows a port to work (or be flagged as not working= on a > given architecture) exactly the same as the "just fix it blanket". >=20 > Intrusive changes should anyway be discussed with the maintainer, and yes= it is > almost impossible to document what is intrusive from what is not, we have= to > rely on common sense here, and if one has a doubt, it is cheap to send a = mail, > open a PR, open a review to the maintainer anyway. >=20 > The change here does not "fix" anything, so in my opinion, seeking for re= view > and opening a discussion with the maintainer would have been a good idea. >=20 > As for whether your change is a good idea or not, I will let you discuss = that > with the maintainer. >=20 > Best regards, > Bapt OK, then if you want me to revert that commit, I can do it. Just note that graphics/gpu-firmware-kmod/Makefile already contained architecture conditional for intel. --=20 --Cnx07BzOhAcsa1xr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmJynAUACgkQelmbhSCD nJ1njw//eNLKsd2lfMKvjEEPVxzym0WXhZkX2ks8n5Yvpl5ENWcaO2VRRhLBXAJO x1wpttDPpI1IEDqSxWuLZTBvqKR0zZci0g1m97lGv7SkMLcUvL7gmvrQAtY2hbvW LYKP31qtr7MsmCKL2ZlxHhsbVV/6S4BVCh/pJJSKoaiW85hZsDE0N6Fylm2mbQoV lv0kkpqIAJFrDxrNCWUhqnGy/dS/KjpDttPefcg+rCbxvF5jwSYYlgCzSBBMoya4 tlC4iT0xeGMI090qwEotatvb+65EovCHJ+laErj/vtSEAuX8MxM39YcFuIW1F0pJ QZhEUJBN6uj823eR+uYcmUay7CyJbjXOyk9sCUpN0JIUempZUC0U0ir4NELg6WIs L/7EJTj+JQzOQWgfH7KYyGDs/3uRO6ZPIRY1roVe5GAzonho/tUu0Kp5m7soMkvF NPo5aeh+L//syhtwVKSNmfI8UiOaRrYeg0mtcUxoIhXe3gZv4jZMoy2At6rAoHft bulSw+vt7c+vKLFHqaFvg4EWzJh3UA+IY0O4uvbIwI4V2Vs6L79qiwmM001xPrlp +oRw2usdSsKGhJLQQYZzLNfJtekXX/VIkP5XzDorap1FKOzCKP5DkTp7oUf2pX+W cFM21DWtDT2poTQP8PjhcanCsBxGwKGpkaQ/LYdBjAzxhItqd9c= =3y/V -----END PGP SIGNATURE----- --Cnx07BzOhAcsa1xr--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YnKcBYPJB3y8Lb%2Bq>