From owner-svn-src-all@FreeBSD.ORG Mon Nov 25 12:41:48 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B305739C; Mon, 25 Nov 2013 12:41:48 +0000 (UTC) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 6E0632699; Mon, 25 Nov 2013 12:41:47 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id OAA20365; Mon, 25 Nov 2013 14:41:45 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1VkvU1-000MIN-7d; Mon, 25 Nov 2013 14:41:45 +0200 Message-ID: <52934551.7050608@FreeBSD.org> Date: Mon, 25 Nov 2013 14:40:49 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Marcel Moolenaar , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r258448 - head/sys/geom/part References: <201311212202.rALM2xAS078472@svn.freebsd.org> In-Reply-To: <201311212202.rALM2xAS078472@svn.freebsd.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Nov 2013 12:41:48 -0000 on 22/11/2013 00:02 Marcel Moolenaar said the following: > Author: marcel > Date: Thu Nov 21 22:02:59 2013 > New Revision: 258448 > URL: http://svnweb.freebsd.org/changeset/base/258448 > > Log: > Have the GPT probe return a lower priority when the MBR is not a PMBR > The purpose of the PMBR is to have the disk appear in use to GPT > unaware utilities (like fdisk). However, if the PMBR has been changed > by a GPT unaware utlity then we must assume that this was deliberate > (as it involved removal of the special slice) and we should not treat > the unmodified GPT-specific sectors as being valid. By lowering the > probe priority in that case, the MBR scheme will take precedence and > the kernel will end up using the MBR and not the GPT. We will still > use the GPT if the kernel does not support the MBR scheme. Thank you very much for this change! Finally I can get rid of my local patch from a while ago: http://thread.gmane.org/gmane.os.freebsd.devel.geom/3776/focus=3802 Your solution is clearly superior while providing the same end result. -- Andriy Gapon