From owner-freebsd-usb@FreeBSD.ORG  Sat Nov  5 12:05:01 2011
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 785F51065670;
	Sat,  5 Nov 2011 12:05:01 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe02.c2i.net [212.247.154.34])
	by mx1.freebsd.org (Postfix) with ESMTP id C1EDF8FC14;
	Sat,  5 Nov 2011 12:05:00 +0000 (UTC)
X-T2-Spam-Status: No, hits=-0.2 required=5.0 tests=ALL_TRUSTED,
	BAYES_50
Received: from [188.126.198.129] (account mc467741@c2i.net HELO
	laptop002.hselasky.homeunix.org)
	by mailfe02.swip.net (CommuniGate Pro SMTP 5.2.19)
	with ESMTPA id 200767084; Sat, 05 Nov 2011 13:04:58 +0100
From: Hans Petter Selasky <hselasky@c2i.net>
To: freebsd-usb@freebsd.org
Date: Sat, 5 Nov 2011 13:02:05 +0100
User-Agent: KMail/1.13.5 (FreeBSD/8.2-STABLE; KDE/4.4.5; amd64; ; )
References: <201111051051.pA5ApEAm025432@red.freebsd.org>
In-Reply-To: <201111051051.pA5ApEAm025432@red.freebsd.org>
X-Face: *nPdTl_}RuAI6^PVpA02T?$%Xa^>@hE0uyUIoiha$pC:9TVgl.Oq, NwSZ4V"|LR.+tj}g5
	%V,x^qOs~mnU3]Gn; cQLv&.N>TrxmSFf+p6(30a/{)KUU!s}w\IhQBj}[g}bj0I3^glmC(
	:AuzV9:.hESm-x4h240C`9=w
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201111051302.05049.hselasky@c2i.net>
Cc: freebsd-gnats-submit@freebsd.org, JD Louw <jl@nanoteq.com>
Subject: Re: usb/162307: [uslcom][patch] cp2103 usb-to-serial driver does
	not support modem control lines
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Nov 2011 12:05:01 -0000

On Saturday 05 November 2011 11:51:14 JD Louw wrote:
> usb/162307

Committed with some modifications:

1) control transfers automatically clear-stall.
2) control transfers should have a timeout
3) flowcontrol[2,3] must be zeroed
4) flowcontrol must be stored in little endian format
5) reduce the interval a little bit, because it is blocking other control 
transfers to this device.
6) reduce control transfer buffer to the request plus 8 bytes, of which only 1 
byte is used.

Please verify and check that my modifications to your patch are correct:
http://svn.freebsd.org/changeset/base/227108

Thanks for the patch!

--HPS