From owner-cvs-all@FreeBSD.ORG Sat May 8 20:39:17 2010 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 313511065676 for ; Sat, 8 May 2010 20:39:17 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with ESMTP id CF0F48FC18 for ; Sat, 8 May 2010 20:39:16 +0000 (UTC) Received: (qmail 11318 invoked by uid 399); 8 May 2010 20:39:16 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 8 May 2010 20:39:16 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4BE5CBF2.2070708@FreeBSD.org> Date: Sat, 08 May 2010 13:39:14 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.9) Gecko/20100330 Thunderbird/3.0.4 MIME-Version: 1.0 To: Dirk Meyer References: <201005081950.o48JoEL7050436@repoman.freebsd.org> In-Reply-To: <201005081950.o48JoEL7050436@repoman.freebsd.org> X-Enigmail-Version: 1.0.1 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/irc/iroffer-dinoex Makefile distinfo ports/irc/iroffer-dinoex/files iroffer-dinoex.in X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 May 2010 20:39:17 -0000 A few problems with the rc.d script. Please see http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html for more information. 1. The file name should match PROVIDE and $name 2. /etc/rc.subr does not need to be in quotes 3. Empty variable assignments are neither useful nor desirable (ala _flags and command_args) 4. There are a couple of places where tests are written like this: [ "${iroffer_dir}" != "" ] They should be changed to [ -n "$iroffer_dir" ] 5. In iroffer_checkdisk() you use echo ... exit. You should use err() instead. See examples in /etc/rc.d. hth, Doug On 05/08/10 12:50, Dirk Meyer wrote: > dinoex 2010-05-08 19:50:14 UTC > > FreeBSD ports repository > > Modified files: > irc/iroffer-dinoex Makefile distinfo > Added files: > irc/iroffer-dinoex/files iroffer-dinoex.in > Log: > - update to 3.21 > - add rc.d script > > Revision Changes Path > 1.14 +2 -2 ports/irc/iroffer-dinoex/Makefile > 1.9 +3 -3 ports/irc/iroffer-dinoex/distinfo > 1.1 +57 -0 ports/irc/iroffer-dinoex/files/iroffer-dinoex.in (new) > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/irc/iroffer-dinoex/Makefile.diff?&r1=1.13&r2=1.14&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/irc/iroffer-dinoex/distinfo.diff?&r1=1.8&r2=1.9&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/irc/iroffer-dinoex/files/iroffer-dinoex.in > -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/