From owner-svn-ports-head@FreeBSD.ORG Mon Feb 10 10:12:20 2014 Return-Path: Delivered-To: svn-ports-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B8BB52A2; Mon, 10 Feb 2014 10:12:20 +0000 (UTC) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6E6A01A9D; Mon, 10 Feb 2014 10:12:20 +0000 (UTC) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id 19870BDC30; Mon, 10 Feb 2014 11:12:19 +0100 (CET) Received: from gw.in.absolight.net (gw-ecl.in.absolight.net [79.143.241.69]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "gw.in.absolight.net", Issuer "CA Cert Signing Authority" (not verified)) by prod2.absolight.net (Postfix) with ESMTPSA id 07DDCBDC2E; Mon, 10 Feb 2014 11:12:19 +0100 (CET) Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239]) by gw.in.absolight.net (Postfix) with ESMTP id C743B6119; Mon, 10 Feb 2014 11:12:17 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by ogg.in.absolight.net (Postfix) with ESMTP id 2DB3E690DC7B; Mon, 10 Feb 2014 11:12:17 +0100 (CET) Date: Mon, 10 Feb 2014 11:12:17 +0100 From: Mathieu Arnold To: David Chisnall , Baptiste Daroussin Subject: Re: svn commit: r343559 - head/net-p2p/litecoin Message-ID: <91D67E64512ADB4F2DA9462F@ogg.in.absolight.net> In-Reply-To: References: <201402092329.s19NTHiq089517@svn.freebsd.org> <20140210011718.GA79272@mouf.net> <20140210075232.GU80056@ithaqua.etoilebsd.net> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Cc: svn-ports-head@FreeBSD.org, Steve Wills , svn-ports-all@FreeBSD.org, John Marino , ports-committers@FreeBSD.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Feb 2014 10:12:20 -0000 +--On 10 f=C3=A9vrier 2014 09:47:17 +0000 David Chisnall = wrote: | On 10 Feb 2014, at 07:52, Baptiste Daroussin wrote: |=20 |> I do not think that requires an approval, as for FreeBSD this change is |> no-op, It is also no intrusive and just "fixes" building of that port |> for Dragonfly. |=20 | Relying on OPSYS and OSVERSION is pretty horrible and doesn't scale. | Already we have problems with convoluted OSVERSION expressions that are | hard to understand and really mean 'fix for PR12345 has been merged to | the relevant branch'. It would be far better to centralise these into a | single file for each platform, listing features / bugfixes / needed | work-arounds and start removing explicit OSVERSION checks from any other | Makefiles. If supporting Dragonfly is one of our objectives, then I'd | strongly encourage the people who are working on it to engage in this | kind of cleanup, rather than piling more hacks into the tree. It is horrible, and as recently shown by the java/openjdk7 update, it doesn't work, but we don't have anything else. --=20 Mathieu Arnold