From owner-svn-src-projects@FreeBSD.ORG Mon Nov 24 06:56:15 2014 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 99C36328; Mon, 24 Nov 2014 06:56:15 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 192D1356; Mon, 24 Nov 2014 06:56:13 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id sAO6pMV7077790 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 24 Nov 2014 09:51:22 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id sAO6pMRR077789; Mon, 24 Nov 2014 09:51:22 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 24 Nov 2014 09:51:22 +0300 From: Gleb Smirnoff To: "Alexander V. Chernikov" Subject: Re: svn commit: r274921 - projects/routing/sys/net Message-ID: <20141124065122.GE47144@FreeBSD.org> References: <201411231747.sANHlC9Y088840@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201411231747.sANHlC9Y088840@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Nov 2014 06:56:15 -0000 On Sun, Nov 23, 2014 at 05:47:12PM +0000, Alexander V. Chernikov wrote: A> Author: melifaro A> Date: Sun Nov 23 17:47:12 2014 A> New Revision: 274921 A> URL: https://svnweb.freebsd.org/changeset/base/274921 A> A> Log: A> Finish r274335#2: put RT_LOCK_DESTROY() back. A> A> Modified: A> projects/routing/sys/net/route.c A> A> Modified: projects/routing/sys/net/route.c A> ============================================================================== A> --- projects/routing/sys/net/route.c Sun Nov 23 17:45:49 2014 (r274920) A> +++ projects/routing/sys/net/route.c Sun Nov 23 17:47:12 2014 (r274921) A> @@ -1505,6 +1505,7 @@ rtrequest1_fib(int req, struct rt_addrin A> if (rn == NULL) { A> ifa_free(rt->rt_ifa); A> Free(rt_key(rt)); A> + RT_LOCK_DESTROY(rt); A> uma_zfree(V_rtzone, rt); A> #ifdef FLOWTABLE A> if (rt0 != NULL) Don't know about your branch, but in head RT_LOCK_DESTROY is done in V_rtzone finit method. So you are going to hit destroying of already destroyed mutex. btw, I see no good reason for virtualizing the zone. (Yep, I did that.) :) -- Totus tuus, Glebius.