From owner-cvs-all Fri Dec 20 10:56:57 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 48CBF37B405; Fri, 20 Dec 2002 10:56:56 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7AD6643EE5; Fri, 20 Dec 2002 10:56:55 -0800 (PST) (envelope-from dillon@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id gBKIutfh074696; Fri, 20 Dec 2002 10:56:55 -0800 (PST) (envelope-from dillon@repoman.freebsd.org) Received: (from dillon@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id gBKIut7s074695; Fri, 20 Dec 2002 10:56:55 -0800 (PST) Message-Id: <200212201856.gBKIut7s074695@repoman.freebsd.org> From: Matt Dillon Date: Fri, 20 Dec 2002 10:56:55 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/usb umass.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG dillon 2002/12/20 10:56:55 PST Modified files: sys/dev/usb umass.c Log: Modify the fake cylinders calculation so it is >= the size of the device, not < the size of the device. This avoids geom complaints. Fix a serious bug in the handling of the RS_NO_CLEAR_UA quirk. When we go and insert the test-unit-ready command the umass_cam_quirk_cb() function sets the status as if the READ_CAPACITY command suceeded when, in fact, it did not. This leads to the CAM layer trying to use garbage in the return buffer and panicing the system (or doing other bad things). Add a quirk entry for MSYSTEMS DISK-ON-KEY, which is sold under the Sony brand as a solid state disk-on-key usb device. This device requires several quirks to work properly. Note that the disk-on-key device will not work properly until CAM also gets a quirk entry for it, which has been submitted to the CAM maintainer, and you may have to temporarily uncomment the DELAY() as well. -current does not properly wait for devices to power up so you may also have to temporarily uncomment the DELAY(300000) to make your device work. A solution must be found to that issue. MFC after: 3 days X-MFC note: the quirk support must MFCd before this patch can be Revision Changes Path 1.68 +26 -6 src/sys/dev/usb/umass.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message