From owner-freebsd-net Sat Jan 18 8:46:52 2003 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A86FB37B4D9 for ; Sat, 18 Jan 2003 08:46:48 -0800 (PST) Received: from morphy.iki.fi (baana-pppoes-213-139-166-84.suomi.net [213.139.166.84]) by mx1.FreeBSD.org (Postfix) with SMTP id 6B2E743F1E for ; Sat, 18 Jan 2003 08:46:47 -0800 (PST) (envelope-from morphy@morphy.iki.fi) Received: (qmail 86404 invoked by uid 1000); 18 Jan 2003 16:46:40 -0000 Date: Sat, 18 Jan 2003 18:46:40 +0200 From: Mikko Hyvarinen To: freebsd-net@freebsd.org, freebsd-current@freebsd.org Subject: [PATCH] Asus A7N8X Deluxe, nForce2 and 3com MAC, Broadcom/Altima PHY Message-ID: <20030118164640.GD36580@morphy.iki.fi> References: <20030112190731.GB14895@morphy.iki.fi> <20030112210430.GA63537@dragon.nuxi.com> <20030113163101.GA714@morphy.iki.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030113163101.GA714@morphy.iki.fi> User-Agent: Mutt/1.4i Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Hi again,O I find it outright odd that the partial patch that didn't help much got committed quickly but the final fix that makes things work didn't. Is there something wrong with the patch or did it just slip through the cracks somewhere? Regards, MSH On Mon, Jan 13, 2003 at 06:31:01PM +0200, Mikko S. Hyvarinen wrote: > On Sun, Jan 12, 2003 at 01:04:30PM -0800, David O'Brien wrote: > > On Sun, Jan 12, 2003 at 09:07:31PM +0200, Mikko S. Hyvarinen wrote: > > > The on-board 3com MAC and Broadcom/Altima PHY are not being detected by the > > > xl(4) driver in -current (cvsup done yesterday evening). > > > In the Award BIOS there is only one setting for the 3com device, a supposed > > > on/off switch with only values Disabled and Auto; I have used Auto. > > ... > > > FWIW, the diff for the files mentioned is attached, in case someone wants > > > to continue from here. > > > > Thanks! I committed this patch so it didn't get lost and maybe someone > > else with one of these boards can take it all the way. > > As usual, it had to be something simple. With the attached change on top > of the previous set the Altima AC101L PHY is detected correctly. > I'm not so sure whether that xl_choose_xcvr() modification is actually > necessary, but one can never be too sure. > > Tested with 10baseT/UTP and it works normally. > > Regards, > MSH > > -- > All opinions expressed above are mine alone and do not express the views > of my employer or any other organizations that I am affiliated with. > Index: sys/pci/if_xl.c > =================================================================== > RCS file: /data/cvs/freebsd/src/sys/pci/if_xl.c,v > retrieving revision 1.121 > diff -u -r1.121 if_xl.c > --- sys/pci/if_xl.c 12 Jan 2003 21:03:38 -0000 1.121 > +++ sys/pci/if_xl.c 13 Jan 2003 16:24:50 -0000 > @@ -1245,6 +1245,7 @@ > case TC_DEVICEID_HURRICANE_656: /* 3c656 */ > case TC_DEVICEID_HURRICANE_656B: /* 3c656B */ > case TC_DEVICEID_TORNADO_656C: /* 3c656C */ > + case TC_DEVICEID_TORNADO_10_100BT_NVIDIA: /* nVidia nForce2 integrated */ > sc->xl_media = XL_MEDIAOPT_MII; > sc->xl_xcvr = XL_XCVR_MII; > if (verbose) > @@ -1340,6 +1341,8 @@ > pci_get_device(dev) == TC_DEVICEID_HURRICANE_656B) > sc->xl_flags |= XL_FLAG_INVERT_MII_PWR | > XL_FLAG_INVERT_LED_PWR; > + if (pci_get_device(dev) == TC_DEVICEID_TORNADO_10_100BT_NVIDIA) > + sc->xl_flags |= XL_FLAG_PHYOK; > > /* > * If this is a 3c905B, we have to check one extra thing. -- All opinions expressed above are mine alone and do not express the views of my employer or any other organizations that I am affiliated with. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message