From owner-freebsd-hackers@FreeBSD.ORG Mon Dec 3 18:50:27 2012 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DE7657CF; Mon, 3 Dec 2012 18:50:27 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from tower.berklix.org (tower.berklix.org [83.236.223.114]) by mx1.freebsd.org (Postfix) with ESMTP id 437E88FC12; Mon, 3 Dec 2012 18:50:25 +0000 (UTC) Received: from mart.js.berklix.net (p57BCF7D2.dip.t-dialin.net [87.188.247.210]) (authenticated bits=128) by tower.berklix.org (8.14.4/8.14.4) with ESMTP id qB3Ip7lh089541; Mon, 3 Dec 2012 19:51:08 +0100 (CET) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41]) by mart.js.berklix.net (8.14.3/8.14.3) with ESMTP id qB3IoDHZ030148; Mon, 3 Dec 2012 19:50:13 +0100 (CET) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (localhost [127.0.0.1]) by fire.js.berklix.net (8.14.4/8.14.4) with ESMTP id qB3Io7nT093977; Mon, 3 Dec 2012 19:50:13 +0100 (CET) (envelope-from jhs@fire.js.berklix.net) Message-Id: <201212031850.qB3Io7nT093977@fire.js.berklix.net> To: hackers@freebsd.org Subject: Missing quote in comment in 8.3 & 9.0 & 9.1RC2 etc/sendmail/freebsd.mc From: "Julian H. Stacey" Organization: http://berklix.com BSD Linux Unix Consultancy, Munich Germany User-agent: EXMH on FreeBSD http://www.berklix.com/free/ X-URL: http://www.berklix.com/~jhs/cv/ Date: Mon, 03 Dec 2012 19:50:07 +0100 Sender: jhs@berklix.com Cc: re@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Dec 2012 18:50:27 -0000 Hi hackers@freebsd.org There is a missing double quote " in 8.3 & 9.0 & 9.1RC2 src/etc/sendmail/freebsd.mc 8.2-RELEASE & earlier are OK. Here's a diff -c to .mc The diff is not to fix it, but to help generate a freebsd.cf to understand the difference. The patch for a fix would befar more trivial :-) ------ *** 9.1-RC3/src/etc/sendmail/freebsd.mc Mon Oct 29 21:16:44 2012 --- 9.1-RC3/src+debug/etc/sendmail/freebsdjhs.mc Mon Dec 3 18:44:33 2012 *************** *** 66,75 **** dnl For that, visit dnl http://www.google.com/Top/Computers/Internet/E-mail/Spam/Blacklists/ ! dnl Uncomment to activate your chosen DNS based blacklist ! dnl FEATURE(dnsbl, `dnsbl.example.com') ! dnl Alternatively, you can provide your own server and rejection message: ! dnl FEATURE(dnsbl, `dnsbl.example.com', ``"550 Mail from " $&{client_addr} " rejected'') dnl Dialup users should uncomment and define this appropriately dnl define(`SMART_HOST', `your.isp.mail.server') --- 66,77 ---- dnl For that, visit dnl http://www.google.com/Top/Computers/Internet/E-mail/Spam/Blacklists/ ! # Uncomment to activate your chosen DNS based blacklist ! FEATURE(dnsbl, `jhs0.dnsbl.example.com') ! # Alternatively, you can provide your own server and rejection message: ! FEATURE(dnsbl, `jhs3.dnsbl.example.com', ``"550 Mail from " $&{client_addr} " rejected'') ! # original line above has 3 x " , line below has 4 ! FEATURE(dnsbl, `jhs4.dnsbl.example.com', ``"550 Mail from " $&{client_addr} " rejected"'') dnl Dialup users should uncomment and define this appropriately dnl define(`SMART_HOST', `your.isp.mail.server') ------ The .cf output is ------ # DNS based IP address spam list jhs0.dnsbl.example.com R$* $: $&{client_addr} R$-.$-.$-.$- $: $(dnsbl $4.$3.$2.$1.jhs0.dnsbl.example.com. $: OK $) ROK $: OKSOFAR R$+ $: TMPOK R$+ $#error $@ 5.7.1 $: "550 Rejected: " $&{client_addr} " listed at jhs0.dnsbl.example.com" # DNS based IP address spam list jhs3.dnsbl.example.com R$* $: $&{client_addr} R$-.$-.$-.$- $: $(dnsbl $4.$3.$2.$1.jhs3.dnsbl.example.com. $: OK $) ROK $: OKSOFAR R$+ $: TMPOK R$+ $#error $@ 5.7.1 $: "550 Mail from " $&{client_addr} " rejected # DNS based IP address spam list jhs4.dnsbl.example.com R$* $: $&{client_addr} R$-.$-.$-.$- $: $(dnsbl $4.$3.$2.$1.jhs4.dnsbl.example.com. $: OK $) ROK $: OKSOFAR R$+ $: TMPOK R$+ $#error $@ 5.7.1 $: "550 Mail from " $&{client_addr} " rejected" ------ Above, jhs3 seems bad & jhs4 seems good. A copy of this diff + follow up is in http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/etc/sendmail/freebsd.mc.REL=ALL.diff The error appeared in 8.3 & 9.0 & 9.1RC3, it was OK earlier : 4.11-RELEASE/src/etc/sendmail/freebsd.mc:dnl FEATURE(dnsbl, `blackholes.mail-abuse.org', `"550 Mail from " $&{client_addr} " rejected, see http://mail-abuse.org/cgi-bin/lookup?" $&{client_addr}') 6.4-RELEASE/src/etc/sendmail/freebsd.mc:dnl FEATURE(dnsbl, `blackholes.mail-abuse.org', ``"550 Mail from " $&{client_addr} " rejected, see http://mail-abuse.org/cgi-bin/lookup?" $&{client_addr}'') 7.3-RELEASE/src/etc/sendmail/freebsd.mc:dnl FEATURE(dnsbl, `blackholes.mail-abuse.org', ``"550 Mail from " $&{client_addr} " rejected, see http://mail-abuse.org/cgi-bin/lookup?" $&{client_addr}'') 7.4-RELEASE/src/etc/sendmail/freebsd.mc:dnl FEATURE(dnsbl, `blackholes.mail-abuse.org', ``"550 Mail from " $&{client_addr} " rejected, see http://mail-abuse.org/cgi-bin/lookup?" $&{client_addr}'') 8.2-RELEASE/src/etc/sendmail/freebsd.mc:dnl FEATURE(dnsbl, `blackholes.mail-abuse.org', ``"550 Mail from " $&{client_addr} " rejected, see http://mail-abuse.org/cgi-bin/lookup?" $&{client_addr}'') 8.3-RELEASE/src/etc/sendmail/freebsd.mc:dnl FEATURE(dnsbl, `dnsbl.example.com', ``"550 Mail from " $&{client_addr} " rejected'') 9.0-RELEASE/src/etc/sendmail/freebsd.mc:dnl FEATURE(dnsbl, `dnsbl.example.com', ``"550 Mail from " $&{client_addr} " rejected'') 9.1-RC3//src/etc/sendmail/freebsd.mc:dnl FEATURE(dnsbl, `dnsbl.example.com', ``"550 Mail from " $&{client_addr} " rejected'') Why others didnt notice earlier: It's just a comment, I assume not checked by anything automatic at freebsd.org. How I caught it: I have my own src/etc/sendmail/ Makefile diffs & fdef'd common.cpp that generates various .mc files for each of my hosts, & many versions, which filters the .cpp to create .mcfiles, inc. a check file that should be an exact match with that version's freebsd.mc ... & cpp complained: unmatched ". I will send-pr unless I hear otherwise. But as 9.1-RELEASE is imminent, & it would be a trivial anodyne fix to a comment for re@ , so they want to fix, so cc'd to re@. Cheers, Julian -- Julian Stacey, BSD Unix Linux C Sys Eng Consultant, Munich http://berklix.com Reply below not above, like a play script. Indent old text with "> ". Send plain text. Not: HTML, multipart/alternative, base64, quoted-printable.