From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Oct 2 23:41:10 2009 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 28BB01065676; Fri, 2 Oct 2009 23:41:10 +0000 (UTC) (envelope-from Fluffy@fluffy.khv.ru) Received: from ns.ael.RU (ns.ael.ru [62.76.207.226]) by mx1.freebsd.org (Postfix) with ESMTP id 6C42A8FC23; Fri, 2 Oct 2009 23:41:09 +0000 (UTC) Received: from Fluffy.Khv.RU ([80.83.238.211]) by ns.ael.RU (8.14.3/8.14.3/Fluffy/5.3) with ESMTP id n92Ner3u049155; Sat, 3 Oct 2009 10:41:00 +1100 (VLAST) (envelope-from Fluffy@fluffy.khv.ru) Received: from fluffy.khv.ru (localhost [127.0.0.1]) by Fluffy.Khv.RU (8.14.3/8.14.3/Fluffy/5.4.1) with ESMTP id n92NeTil095166; Sat, 3 Oct 2009 10:40:33 +1100 (VLAST) (envelope-from Fluffy@fluffy.khv.ru) From: Dima Panov Organization: Twilight Zone To: freebsd-ports-bugs@freebsd.org Date: Sat, 3 Oct 2009 10:40:23 +1100 User-Agent: KMail/1.12.1 (FreeBSD/9.0-900002-CURRENT; KDE/4.3.1; amd64; ; ) References: <200910021923.n92JNGb5022670@www.freebsd.org> In-Reply-To: <200910021923.n92JNGb5022670@www.freebsd.org> X-Face: "RE-2'yS-N:*/7DHOjQ%Az<.+SG>K7B'k(&; qb0K4]Hv>J}"l9,=:m2_]-3S/}`b\]yA-g !y3en*Zl(i-86iM?Q[w@!=rW&JdT>KHW@dri>+qMcy42O, 5#izEqa-K+=B<@A X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (ns.ael.RU [62.76.207.226]); Sat, 03 Oct 2009 10:41:04 +1100 (VLAST) X-Spam-Status: No, score=-7.5 required=3.0 tests=AWL,BAYES_00,RDNS_NONE, SPF_FAIL,SPF_HELO_FAIL autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on ns.ael.RU Cc: freebsd-gnats-submit@freebsd.org, Matt Tosto Subject: Re: ports/139315: [MAINTAINER] audio/liblastfm - fix build with custom PREFIX X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2009 23:41:10 -0000 --nextPart1432490.MpRoJcWnX6 Content-Type: multipart/mixed; boundary="Boundary-01=_o9oxK4JZYIUiw19" Content-Transfer-Encoding: 7bit --Boundary-01=_o9oxK4JZYIUiw19 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Saturday 03 October 2009 06:23:16 Matt Tosto wrote: > >Number: 139315 >=20 > Build failed when custom PREFIX was set due to an incorrect formatting of > the CONFIGURE_ARGS in the port Makefile. Small attached patch corrects > this issue. I'm not entirely sure if ${PREFIX} or ${LOCALBASE} is the > proper substitution to use in the Makefile. Confirmation of this would = be > appreciated. >=20 > Patch attached with submission follows: >=20 > diff -U3 -r ../liblastfm/Makefile /usr/ports/audio/liblastfm/Makefile > --- ../liblastfm/Makefile 2009-10-01 10:44:58.000000000 -0500 > +++ /usr/ports/audio/liblastfm/Makefile 2009-09-08 08:45:41.000000000 -05= 00 > @@ -23,7 +23,7 @@ > QT_COMPONENTS=3D corelib xml network sql gui qtestlib \ > qmake_build moc_build rcc_build uic_build > HAS_CONFIGURE=3D yes > -CONFIGURE_ARGS+=3D --prefix ${LOCALBASE} --release > +CONFIGURE_ARGS+=3D -release > MAKE_JOBS_UNSAFE=3D yes >=20 > USE_LDCONFIG=3D yes Patch reversed, right?=20 Args order also had a side effect. =2D-=20 Dima "Red Fox" Panov @ Home | C73E 2B72 1FFD 61BD E206 1234 A626 76ED 93E3 = B018 Khabarovsk, Russia | 2D30 2CCB 9984 130C 6F87 BAFC FB8B A09D D539 = 8F29 KDE@FreeBSD Team | FreeBSD committer since 10.08.2009 | FreeBSD since Sept = 1995 Twitter.com:fluffy_khv | Skype:dima.panov | Jabber.org:fluffy.khv | ICQ:174= 5024 --Boundary-01=_o9oxK4JZYIUiw19 Content-Type: text/x-patch; charset="UTF-8"; name="liblastfm.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="liblastfm.diff" Index: audio/liblastfm/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/ncvs/ports/audio/liblastfm/Makefile,v retrieving revision 1.5 diff -u -r1.5 Makefile =2D-- audio/liblastfm/Makefile 5 Sep 2009 12:31:33 -0000 1.5 +++ audio/liblastfm/Makefile 2 Oct 2009 23:37:28 -0000 @@ -23,7 +23,7 @@ QT_COMPONENTS=3D corelib xml network sql gui qtestlib \ qmake_build moc_build rcc_build uic_build HAS_CONFIGURE=3D yes =2DCONFIGURE_ARGS+=3D -release +CONFIGURE_ARGS+=3D --release --prefix=3D${LOCALBASE} MAKE_JOBS_UNSAFE=3D yes =20 USE_LDCONFIG=3D yes --Boundary-01=_o9oxK4JZYIUiw19-- --nextPart1432490.MpRoJcWnX6 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.13 (FreeBSD) iEYEABECAAYFAkrGj2wACgkQpiZ27ZPjsBiEGwCg4KH0/vDZb1e+yHqaL22m+j4Z it0AnAmcNUIy//ZQz0SBFoTefHZDZl2i =xzCl -----END PGP SIGNATURE----- --nextPart1432490.MpRoJcWnX6--