From nobody Tue Jul 14 14:56:13 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h02SF3bG9z6kqdh for ; Tue, 14 Jul 2026 14:56:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h02SF1Q5Bz3Lxs for ; Tue, 14 Jul 2026 14:56:13 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784040973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rWNgVKaFsH+x/o3rIguVqK4YDvaTuyPv6BsHZX4KJeQ=; b=d9xB+7i2dQjW3Qky1qra8bbYsfmwHxopKStWK2fnhkzb6MELnFYirCUFT4CEoWjIThymnk fWV+O+alrRyH/rmc7SZQuEHNMnIAuTkvHE3iJsvFPFR3Xiouqnj5IgnfZpDtc9n+7OTZ2b eOd6fp2j3Ifsf4U33RbJxYLp2HuMJCKC+V3nnhnLCn4YezGp1tM3CEaopVZnpy6krjrXoK aPWkrI1MJMaa7IJkDkTktyINYZfaIxtEe7r5HKaE3+WNPfHTZt9k3LZDseqkGhez6uydNa 4uox8IYE1dFRXSWXuGrmQnSZ5L+VOISsn0jOEFXDBlX9ope+4/cfuGJ1oM1XQg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1784040973; a=rsa-sha256; cv=none; b=wsmNik5ldypF2zsin+ih4FaUJtp2lEFA67HEjZg01AYttNt6hULW9AXJ/AxWm0P+iydgDc YwHaJapQNmwy9GVh5POs4VeEgz1O4PsYQI9YXDCjPyQ173OnO0479N/R24OWXen6808FHb iJgbnHv9BN4GTLizwakv8AAXgQcDWC6z+HWMRiQBFu9jr+Rm4a0ECO0915EMalbRhVRhqO JHnk6d0hoAJ1RuKXJ/+3Og9eokflCFbEvIdNo0zrihyF+Aho3dYGgP5r0LaTrL4OeM2Ni3 FmhxewrBiNEJCH91Z92ii2q+iwSHob3RO4B3EUeIwpAx5cbH4cTBa1pvuXDJOQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784040973; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rWNgVKaFsH+x/o3rIguVqK4YDvaTuyPv6BsHZX4KJeQ=; b=xjLS/QcBRGMUC7klmrFVWR3O1/RxBAmDctsRxRM7ipkAE4ZPOJRTCSaMfuuaLIScy4xTUO YgN+HjeDd2JRGjCb9Ahuq6FEjjA/dMrcDFyw8VUJ7dHeIGXLcosFCSkVgoQ8NaysMptOU7 UKh906h+e/AOgowwvuCPmnNwX90a5JLC2NUn7XTB6QU9ucGZ4Za4vyN+h2lDGTAqu5Na7O UPHjJQ9j4ipVxJO61Tz1bu1mKRX7drgiqQdCiORqRdCAeDt5gT0QigWDs6koy4tkIoKSIL F9sExkIeaLngtT3gDwuplndmBmXBrIAH5ZbgoC9MblJs3hKMuLUPqke/kZ/O7Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h02SF0B2Wzq5H for ; Tue, 14 Jul 2026 14:56:13 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3d68d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 14 Jul 2026 14:56:13 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: d4b1fe786860 - stable/14 - netinet tests: Fix leaks in ip6_v4mapped_test List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: d4b1fe786860c0ab56c14a08b9555816fd44bd52 Auto-Submitted: auto-generated Date: Tue, 14 Jul 2026 14:56:13 +0000 Message-Id: <6a564e0d.3d68d.419f47c9@gitrepo.freebsd.org> The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=d4b1fe786860c0ab56c14a08b9555816fd44bd52 commit d4b1fe786860c0ab56c14a08b9555816fd44bd52 Author: Mark Johnston AuthorDate: 2023-10-20 14:05:58 +0000 Commit: Mark Johnston CommitDate: 2026-07-14 14:08:40 +0000 netinet tests: Fix leaks in ip6_v4mapped_test Reported by: Coverity MFC after: 1 week (cherry picked from commit 6ad6929974e6394d57a40f7d43c899963c6ae5ec) --- tests/sys/netinet/ip6_v4mapped_test.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/sys/netinet/ip6_v4mapped_test.c b/tests/sys/netinet/ip6_v4mapped_test.c index d4c4ed526ab5..bbc8d11d63ef 100644 --- a/tests/sys/netinet/ip6_v4mapped_test.c +++ b/tests/sys/netinet/ip6_v4mapped_test.c @@ -294,8 +294,7 @@ ATF_TC_BODY(tcp_v4mapped_bind, tc) error = connect(csock, &su_mapped.saddr, su_mapped.saddr.sa_len); if (error != 0 && errno == EADDRINUSE) { /* This is the specific error we were looking for. */ - ATF_REQUIRE_MSG(error == 0, - "client connect %d failed, " + atf_tc_fail("client connect %d failed, " " client had duplicate port: %s", i, strerror(errno)); } @@ -312,6 +311,8 @@ ATF_TC_BODY(tcp_v4mapped_bind, tc) } ATF_REQUIRE_MSG(i >= 1, "No successful connections"); ATF_REQUIRE_MSG(got_bind_error == true, "No expected bind error"); + + ATF_REQUIRE(close(lsock) == 0); } ATF_TC_CLEANUP(tcp_v4mapped_bind, tc) { @@ -365,6 +366,7 @@ ATF_TC_BODY(udp_v4mapped_sendto, tc) ATF_REQUIRE_MSG(error == 0, "getaddrinfo: %s", gai_strerror(error)); memcpy(&sin6, aip->ai_addr, sizeof(sin6)); sin6.sin6_port = port; + freeaddrinfo(aip); ch = 0x42; n = sendto(s, &ch, 1, 0, (struct sockaddr *)&sin6, sizeof(sin6)); @@ -383,6 +385,9 @@ ATF_TC_BODY(udp_v4mapped_sendto, tc) n = recv(ls, &ch, 1, 0); ATF_REQUIRE_MSG(n == 1, "recv() failed: %s", strerror(errno)); ATF_REQUIRE(ch == 0x42); + + ATF_REQUIRE(close(s) == 0); + ATF_REQUIRE(close(ls) == 0); } ATF_TP_ADD_TCS(tp)