From owner-freebsd-ports@FreeBSD.ORG Tue Aug 15 09:39:38 2006 Return-Path: X-Original-To: freebsd-ports@FreeBSD.org Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9707B16A4DD; Tue, 15 Aug 2006 09:39:38 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from server.t-hosting.hu (server.t-hosting.hu [217.20.133.7]) by mx1.FreeBSD.org (Postfix) with ESMTP id 956B543D70; Tue, 15 Aug 2006 09:39:33 +0000 (GMT) (envelope-from gabor@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by server.t-hosting.hu (Postfix) with ESMTP id AD24399C63A; Tue, 15 Aug 2006 11:39:32 +0200 (CEST) X-Virus-Scanned: amavisd-new at t-hosting.hu Received: from server.t-hosting.hu ([127.0.0.1]) by localhost (server.t-hosting.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id yOIu66urRP6a; Tue, 15 Aug 2006 11:39:32 +0200 (CEST) Received: from [192.168.2.186] (catv-50635cb6.catv.broadband.hu [80.99.92.182]) by server.t-hosting.hu (Postfix) with ESMTP id 138E599C636; Tue, 15 Aug 2006 11:39:32 +0200 (CEST) Message-ID: <44E1964F.8060500@FreeBSD.org> Date: Tue, 15 Aug 2006 11:39:27 +0200 From: =?UTF-8?B?R8OhYm9yIEvDtnZlc2TDoW4=?= User-Agent: Thunderbird 1.5.0.5 (Windows/20060719) MIME-Version: 1.0 To: Sergey Matveychuk References: <20060814234414.GA57035@hades.panopticon> <44E16DF6.20705@FreeBSD.org> In-Reply-To: <44E16DF6.20705@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-ports@FreeBSD.org Subject: Re: ATTENTION: is the way DESTDIR was introduced completely wrong? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Aug 2006 09:39:38 -0000 Sergey Matveychuk wrote: > Dmitry Marakasov wrote: > >> What I propose is: >> - Change variable naming scheme. >> All *BASE and *DIR vars should be reverted to their original meanings >> (i.e. local paths). Instead, INSTALL_ vars should be introduced: >> INSTALL_LOCALBASE=${DESTDIR}/${LOCALBASE} >> INSTALL_X11BASE=${DESTDIR}/${X11BASE} >> INSTALL_PREFIX=${DESTDIR}/${PREFIX} >> INSTALL_DATADIR=${DESTDIR}/${DATADIR} >> >> etc. These should be used in do-install target. >> >> * This is far more clean and understandable, >> * This allows us to make all ports (around 5k) that define do-install target >> DESTDIR-compatible (there still may be issues, but nevertheless). >> >> > > I agree with every your word. > I was to implement it in this way, but as I said this would require us to change all of the *_DEPENDS lines. Erwin told me that this can't be happen, so I was pushed to go the another way. Erwin is in portmgr, and portmgr's word make sense in these questions... > >> - Introduce variable DESTDIR_COMPATIBLE to explititely mark >> DESTDIR-compatible ports. >> * I don't think DESTDIR compatibility can be tested automatically, so >> this would make freebsd user's life easier (user will be sure that after he >> installs ports into [jail|other freebsd installation mounted via >> nfs|locally] being set corresponging DESTDIR, nothing will break). >> Without such variable, he'll never be sure. >> * Port maintainers will know what ports still are to be converted. >> Nothing will be forgotten. >> >> > > This is exactly I proposed. But I've not been heard. > You have been, but this will happen later, after an -exp run as Erwin said. And in the opposite form. Ports that don't respect DESTDIR will be marked. -- Cheers, Gabor