Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 05 Feb 2025 13:50:04 -0800
From:      Cy Schubert <Cy.Schubert@cschubert.com>
To:        Konstantin Belousov <kib@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: 53ece2bea9ff - main - audit(9): do not touch VFS if  panicing
Message-ID:  <20250205215004.6F61118A@slippy.cwsent.com>
In-Reply-To: <202502052142.515Lg7O9095895@gitrepo.freebsd.org>
References:  <202502052142.515Lg7O9095895@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
In message <202502052142.515Lg7O9095895@gitrepo.freebsd.org>, Konstantin 
Belous
ov writes:
> The branch main has been updated by kib:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=53ece2bea9ffa654aaa50e5ed6634116
> 0194179f
>
> commit 53ece2bea9ffa654aaa50e5ed66341160194179f
> Author:     Konstantin Belousov <kib@FreeBSD.org>
> AuthorDate: 2025-01-30 10:45:04 +0000
> Commit:     Konstantin Belousov <kib@FreeBSD.org>
> CommitDate: 2025-02-05 21:41:01 +0000
>
>     audit(9): do not touch VFS if panicing
>     
>     Reported by:    bz
> ---
>  sys/security/audit/audit.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sys/security/audit/audit.c b/sys/security/audit/audit.c
> index 269e62db454a..8a9865bf233b 100644
> --- a/sys/security/audit/audit.c
> +++ b/sys/security/audit/audit.c
> @@ -396,7 +396,8 @@ SYSINIT(audit_init, SI_SUB_AUDIT, SI_ORDER_FIRST, audit_i
> nit, NULL);
>  void
>  audit_shutdown(void *arg, int howto)
>  {
> -
> +	if (KERNEL_PANICED())

Should this not be KERNEL_PANICKED?

> +		return;
>  	audit_rotate_vnode(NULL, NULL);
>  }
>  
>


-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  https://FreeBSD.org
NTP:           <cy@nwtime.org>    Web:  https://nwtime.org

			e^(i*pi)+1=0





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20250205215004.6F61118A>