From owner-freebsd-bugs@freebsd.org  Sun Jan 24 17:57:25 2016
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 292DD754D
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Sun, 24 Jan 2016 17:57:25 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 19FB4260
 for <freebsd-bugs@FreeBSD.org>; Sun, 24 Jan 2016 17:57:25 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u0OHvO1R019215
 for <freebsd-bugs@FreeBSD.org>; Sun, 24 Jan 2016 17:57:24 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 206585] hpt_set_info possible buffer overflow
Date: Sun, 24 Jan 2016 17:57:25 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: ecturt@gmail.com
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-206585-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Jan 2016 17:57:25 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206585

            Bug ID: 206585
           Summary: hpt_set_info possible buffer overflow
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: ecturt@gmail.com

In `hpt_status` -> `hpt_set_info`, `nOutBufferSize` and `nInBufferSize` are
checked at the same time, but not individually:

if (piop->nInBufferSize+piop->nOutBufferSize > PAGE_SIZE) {
        KdPrintE(("User buffer too large\n"));
        return -EINVAL;
}

Before performing a kernel allocation:

ke_area =3D malloc(piop->nInBufferSize+piop->nOutBufferSize, M_DEVBUF, M_NO=
WAIT);

However, the sizes are later used individually for some copies:

if (piop->nInBufferSize)
        copyin((void*)(ULONG_PTR)piop->lpInBuffer, ke_area,
piop->nInBufferSize);

...

if (piop->nOutBufferSize)
        copyout(ke_area + piop->nInBufferSize,
(void*)(ULONG_PTR)piop->lpOutBuffer, piop->nOutBufferSize);

It might be possible for `nInBufferSize`, or `outBufferSize`, or both, to be
large enough for `piop->nInBufferSize+piop->nOutBufferSize` to overflow and=
 be
less than `PAGE_SIZE`.

In this situation the copy calls would result in a heap overflow.

--=20
You are receiving this mail because:
You are the assignee for the bug.=